Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: src/objects.h

Issue 1705713002: [runtime] Replace hidden_string with a 0-hash-code private symbol (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/heap/heap.cc ('K') | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 0e50a3b8f604504d3ddbe87e3a214b7238bdd9f1..f45d687c4ba3bf9a54709509d4cdc33a14f59247 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -2193,12 +2193,11 @@ class JSObject: public JSReceiver {
// Accessors for hidden properties object.
//
- // Hidden properties are not own properties of the object itself.
- // Instead they are stored in an auxiliary structure kept as an own
- // property with a special name Heap::hidden_string(). But if the
- // receiver is a JSGlobalProxy then the auxiliary object is a property
- // of its prototype, and if it's a detached proxy, then you can't have
- // hidden properties.
+ // Hidden properties are not own properties of the object itself. Instead
+ // they are stored in an auxiliary structure kept as an own property with a
+ // special name Heap::hidden_properties_symbol(). But if the receiver is a
+ // JSGlobalProxy then the auxiliary object is a property of its prototype, and
+ // if it's a detached proxy, then you can't have hidden properties.
// Sets a hidden property on this object. Returns this object if successful,
// undefined if called on a detached proxy.
@@ -8978,9 +8977,6 @@ class String: public Name {
static const uint32_t kMaxUtf16CodeUnitU = kMaxUtf16CodeUnit;
static const uc32 kMaxCodePoint = 0x10ffff;
- // Value of hash field containing computed hash equal to zero.
- static const int kEmptyStringHash = kIsNotArrayIndexMask;
-
// Maximal string length.
static const int kMaxLength = (1 << 28) - 16;
« src/heap/heap.cc ('K') | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698