src/lookup.h - Issue 1705713002: [runtime] Replace hidden_string with a 0-hash-code private symbol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.h

Issue 1705713002: [runtime] Replace hidden_string with a 0-hash-code private symbol (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.h

diff --git a/src/lookup.h b/src/lookup.h

index 2f53832b1fa845d2af26a7b68e48063acb3f5bf3..2b76d3c2e3de0593c877f588dcbc8cea45f2311b 100644

--- a/src/lookup.h

+++ b/src/lookup.h

@@ -209,7 +209,7 @@ class LookupIterator final BASE_EMBEDDED {

bool ExtendingNonExtensible(Handle<JSObject> receiver) {

DCHECK(receiver.is_identical_to(GetStoreTarget()));

return !receiver->map()->is_extensible() &&

- (IsElement() || !isolate_->IsInternallyUsedPropertyName(name_));

+ (IsElement() || !name_->IsPrivate());

}

void PrepareForDataProperty(Handle<Object> value);

void PrepareTransitionToDataProperty(Handle<JSObject> receiver,

« src/heap/heap.cc ('K') | « src/isolate.cc ('k') | src/lookup.cc » ('j') | no next file with comments »