src/ic/ic.cc - Issue 1705713002: [runtime] Replace hidden_string with a 0-hash-code private symbol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 1705713002: [runtime] Replace hidden_string with a 0-hash-code private symbol (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index dcd01cd292b74b459b9c141fa7f7e8e392644959..72519faef4a0ff08221625a554667c33bf8ecbe0 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1693,8 +1693,7 @@ Handle<Code> StoreIC::CompileHandler(LookupIterator* lookup,

// This is currently guaranteed by checks in StoreIC::Store.

Handle<JSObject> receiver = Handle<JSObject>::cast(lookup->GetReceiver());

Handle<JSObject> holder = lookup->GetHolder<JSObject>();

- DCHECK(!receiver->IsAccessCheckNeeded() ||

- isolate()->IsInternallyUsedPropertyName(lookup->name()));

+ DCHECK(!receiver->IsAccessCheckNeeded() || lookup->name()->IsPrivate());

switch (lookup->state()) {

case LookupIterator::TRANSITION: {

« src/heap/heap.cc ('K') | « src/heap/heap.cc ('k') | src/isolate.h » ('j') | no next file with comments »