DevTools: migrate remote debugging protocol generators to jinja2.

DevTools: migrate remote debugging protocol generators to jinja2.

BUG=580337
Committed: https://crrev.com/10924eea919977e800165ab7e10adaa7b495a65f
Cr-Commit-Position: refs/heads/master@{#376929}

[pfeldman, 2016-02-22 20:39:10]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-02-22 20:39:11]

PTAL :)

[pfeldman, 2016-02-22 23:02:51]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 23:04:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702673002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702673002/220001

[commit-bot: I haz the power, 2016-02-22 23:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 23:10:49]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-02-22 23:51:36]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 23:52:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702673002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702673002/240001

[dgozman, 2016-02-22 23:57:36]

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
(right):

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp:354: if
(!tile) {
I believe this does not happen anymore.

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp:765:
childrenArray =
TypeBuilder::Array<TypeBuilder::Page::FrameResourceTree>::create();
This could be done unconditionally, and |if (childrenArray)| could be removed.

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
(right):

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:200:
"create_type": "adoptPtr(new <protocol::TypeBuilder::Array<%s>)" %
type["raw_type"],
typo: new <protocol

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:218:
items_type = type["items"]["type"]
What about $ref? Should be easy.

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:372:
*columnNumber = location->hasColumnNumber() ? location->getColumnNumber() : 0;
getColumnNumber(0)

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:398: if
(actualLocation)
if (*actualLocation)

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:605:
location->setColumnNumber(actualColumnNumber);
Chain it.

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
(right):

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp:31:
m_frontend->reportHeapSnapshotProgress(done, total,
protocol::TypeBuilder::OptionalValue<bool>());
We could use default parameters to simplify such calls.

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp (right):

https://codereview.chromium.org/1702673002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:762: || commandName ==
"Debugger.setBreakpointCmd"
kill Cmd

[dgozman, 2016-02-23 00:06:43]

lgtm

[commit-bot: I haz the power, 2016-02-23 00:25:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 00:25:26]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pfeldman, 2016-02-23 00:55:35]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-02-23 00:55:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1702673002/#ps260001
(title: "for landing")

[commit-bot: I haz the power, 2016-02-23 00:56:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702673002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702673002/260001

[commit-bot: I haz the power, 2016-02-23 01:16:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 01:16:23]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[pfeldman, 2016-02-23 01:16:48]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-02-23 01:16:49]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1702673002/#ps280001
(title: " ")

[commit-bot: I haz the power, 2016-02-23 01:18:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702673002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702673002/280001

[commit-bot: I haz the power, 2016-02-23 02:30:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 02:30:23]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[pfeldman, 2016-02-23 04:03:08]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-02-23 04:03:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1702673002/#ps300001
(title: " ")

[commit-bot: I haz the power, 2016-02-23 04:04:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702673002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702673002/300001

[commit-bot: I haz the power, 2016-02-23 05:18:07]

Committed patchset #16 (id:300001)

[commit-bot: I haz the power, 2016-02-23 05:19:36]

Description was changed from

==========
DevTools: migrate remote debugging protocol generators to jinja2.

BUG=580337
==========

to

==========
DevTools: migrate remote debugging protocol generators to jinja2.

BUG=580337

Committed: https://crrev.com/10924eea919977e800165ab7e10adaa7b495a65f
Cr-Commit-Position: refs/heads/master@{#376929}
==========

[commit-bot: I haz the power, 2016-02-23 05:19:38]

Patchset 16 (id:??) landed as
https://crrev.com/10924eea919977e800165ab7e10adaa7b495a65f
Cr-Commit-Position: refs/heads/master@{#376929}