Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
index c5fad59c6ad7deb02d79bab4974e511669f7c2af..12d78eae1ac376e5cc6b9f5f6c4fce1c54c1c10f 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
@@ -66,15 +66,16 @@ public:
DECLARE_VIRTUAL_TRACE();
// DOMDebugger API for InspectorFrontend
- void setXHRBreakpoint(ErrorString*, const String& url) override;
- void removeXHRBreakpoint(ErrorString*, const String& url) override;
- void setEventListenerBreakpoint(ErrorString*, const String& eventName, const String* targetName) override;
- void removeEventListenerBreakpoint(ErrorString*, const String& eventName, const String* targetName) override;
- void setInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
- void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
void setDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;
void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;
- void getEventListeners(ErrorString*, const String& objectId, RefPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::DOMDebugger::EventListener>>& result) override;
+ void setEventListenerBreakpoint(ErrorString*, const String& eventName, const OptionalValue<String>& targetName) override;
+ void removeEventListenerBreakpoint(ErrorString*, const String& eventName, const OptionalValue<String>& targetName) override;
+ void setInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
+ void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
+ void setXHRBreakpoint(ErrorString*, const String& url) override;
+ void removeXHRBreakpoint(ErrorString*, const String& url) override;
+ void getEventListeners(ErrorString*, const String& objectId, OwnPtr<protocol::Array<protocol::DOMDebugger::EventListener>>* listeners) override;
+
// InspectorInstrumentation API
void willInsertDOMNode(Node* parent);
void didInvalidateStyleAttr(Node*);
@@ -115,15 +116,15 @@ private:
void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion, JSONObject* description);
void updateSubtreeBreakpoints(Node*, uint32_t rootMask, bool set);
bool hasBreakpoint(Node*, int type);
- void setBreakpoint(ErrorString*, const String& eventName, const String* targetName);
- void removeBreakpoint(ErrorString*, const String& eventName, const String* targetName);
+ void setBreakpoint(ErrorString*, const String& eventName, const String& targetName);
+ void removeBreakpoint(ErrorString*, const String& eventName, const String& targetName);
void didAddBreakpoint();
void didRemoveBreakpoint();
void setEnabled(bool);
- void eventListeners(v8::Local<v8::Context>, v8::Local<v8::Value>, const String& objectGroup, RefPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::DOMDebugger::EventListener>>& listenersArray);
- PassRefPtr<protocol::TypeBuilder::DOMDebugger::EventListener> buildObjectForEventListener(v8::Local<v8::Context>, const V8EventListenerInfo&, const String& objectGroupId);
+ void eventListeners(v8::Local<v8::Context>, v8::Local<v8::Value>, const String& objectGroup, protocol::Array<protocol::DOMDebugger::EventListener>* listenersArray);
+ PassOwnPtr<protocol::DOMDebugger::EventListener> buildObjectForEventListener(v8::Local<v8::Context>, const V8EventListenerInfo&, const String& objectGroupId);
v8::Isolate* m_isolate;
RawPtrWillBeMember<InspectorDOMAgent> m_domAgent;

Powered by Google App Engine
This is Rietveld 408576698