Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
index c3617db6be636f6a979ad65d64b934b8159c83e9..917f74bbb89a30c60548c8f0dd5ab097ef724166 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
@@ -73,15 +73,15 @@ V8StackTraceImpl::Frame::~Frame()
// buildInspectorObject() and ScriptCallStack's toTracedValue() should set the same fields.
// If either of them is modified, the other should be also modified.
-PassRefPtr<protocol::TypeBuilder::Runtime::CallFrame> V8StackTraceImpl::Frame::buildInspectorObject() const
+PassOwnPtr<protocol::Runtime::CallFrame> V8StackTraceImpl::Frame::buildInspectorObject() const
{
- return protocol::TypeBuilder::Runtime::CallFrame::create()
+ return protocol::Runtime::CallFrame::create()
.setFunctionName(m_functionName)
.setScriptId(m_scriptId)
.setUrl(m_scriptName)
.setLineNumber(m_lineNumber)
.setColumnNumber(m_columnNumber)
- .release();
+ .build();
}
PassOwnPtr<V8StackTraceImpl> V8StackTraceImpl::create(V8DebuggerAgentImpl* agent, v8::Local<v8::StackTrace> stackTrace, size_t maxStackSize)
@@ -157,19 +157,19 @@ String V8StackTraceImpl::topScriptId() const
return m_frames[0].m_scriptId;
}
-PassRefPtr<protocol::TypeBuilder::Runtime::StackTrace> V8StackTraceImpl::buildInspectorObject() const
+PassOwnPtr<protocol::Runtime::StackTrace> V8StackTraceImpl::buildInspectorObject() const
{
- RefPtr<protocol::TypeBuilder::Array<protocol::TypeBuilder::Runtime::CallFrame>> frames = protocol::TypeBuilder::Array<protocol::TypeBuilder::Runtime::CallFrame>::create();
+ OwnPtr<protocol::Array<protocol::Runtime::CallFrame>> frames = protocol::Array<protocol::Runtime::CallFrame>::create();
for (size_t i = 0; i < m_frames.size(); i++)
frames->addItem(m_frames.at(i).buildInspectorObject());
- RefPtr<protocol::TypeBuilder::Runtime::StackTrace> stackTrace = protocol::TypeBuilder::Runtime::StackTrace::create()
- .setCallFrames(frames.release());
+ OwnPtr<protocol::Runtime::StackTrace> stackTrace = protocol::Runtime::StackTrace::create()
+ .setCallFrames(frames.release()).build();
if (!m_description.isEmpty())
stackTrace->setDescription(m_description);
if (m_parent)
stackTrace->setParent(m_parent->buildInspectorObject());
- return stackTrace;
+ return stackTrace.release();
}
String V8StackTraceImpl::toString() const

Powered by Google App Engine
This is Rietveld 408576698