Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h
diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h b/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h
index ba21491959e4cafde344b298c7a78920e0945b22..c56ed6b2bfc93c075f25fa20ed152d28da6e6380 100644
--- a/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h
+++ b/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h
@@ -12,33 +12,20 @@
namespace blink {
-using protocol::TypeBuilder::Accessibility::AXGlobalStates;
-using protocol::TypeBuilder::Accessibility::AXLiveRegionAttributes;
-using protocol::TypeBuilder::Accessibility::AXProperty;
-using protocol::TypeBuilder::Accessibility::AXValueType;
-using protocol::TypeBuilder::Accessibility::AXRelationshipAttributes;
-using protocol::TypeBuilder::Accessibility::AXValue;
-using protocol::TypeBuilder::Accessibility::AXValueSource;
-using protocol::TypeBuilder::Accessibility::AXWidgetAttributes;
-using protocol::TypeBuilder::Accessibility::AXWidgetStates;
-
-PassRefPtr<AXProperty> createProperty(String name, PassRefPtr<AXValue>);
-PassRefPtr<AXProperty> createProperty(AXGlobalStates::Enum name, PassRefPtr<AXValue>);
-PassRefPtr<AXProperty> createProperty(AXLiveRegionAttributes::Enum name, PassRefPtr<AXValue>);
-PassRefPtr<AXProperty> createProperty(AXRelationshipAttributes::Enum name, PassRefPtr<AXValue>);
-PassRefPtr<AXProperty> createProperty(AXWidgetAttributes::Enum name, PassRefPtr<AXValue>);
-PassRefPtr<AXProperty> createProperty(AXWidgetStates::Enum name, PassRefPtr<AXValue>);
-PassRefPtr<AXProperty> createProperty(IgnoredReason);
-
-PassRefPtr<AXValue> createValue(String value, AXValueType::Enum = AXValueType::String);
-PassRefPtr<AXValue> createValue(int value, AXValueType::Enum = AXValueType::Integer);
-PassRefPtr<AXValue> createValue(float value, AXValueType::Enum = AXValueType::Number);
-PassRefPtr<AXValue> createBooleanValue(bool value, AXValueType::Enum = AXValueType::Boolean);
-PassRefPtr<AXValue> createRelatedNodeListValue(const AXObject*, String* name = nullptr, AXValueType::Enum = AXValueType::Idref);
-PassRefPtr<AXValue> createRelatedNodeListValue(AXRelatedObjectVector&, AXValueType::Enum);
-PassRefPtr<AXValue> createRelatedNodeListValue(AXObject::AXObjectVector& axObjects, AXValueType::Enum = AXValueType::IdrefList);
-
-PassRefPtr<AXValueSource> createValueSource(NameSource&);
+using namespace protocol::Accessibility;
+
+PassOwnPtr<AXProperty> createProperty(const String& name, PassOwnPtr<AXValue>);
+PassOwnPtr<AXProperty> createProperty(IgnoredReason);
+
+PassOwnPtr<AXValue> createValue(const String& value, const String& type = AXValueTypeEnum::String);
+PassOwnPtr<AXValue> createValue(int value, const String& type = AXValueTypeEnum::Integer);
+PassOwnPtr<AXValue> createValue(float value, const String& valueType = AXValueTypeEnum::Number);
+PassOwnPtr<AXValue> createBooleanValue(bool value, const String& valueType = AXValueTypeEnum::Boolean);
+PassOwnPtr<AXValue> createRelatedNodeListValue(const AXObject*, String* name = nullptr, const String& valueType = AXValueTypeEnum::Idref);
+PassOwnPtr<AXValue> createRelatedNodeListValue(AXRelatedObjectVector&, const String& valueType);
+PassOwnPtr<AXValue> createRelatedNodeListValue(AXObject::AXObjectVector& axObjects, const String& valueType = AXValueTypeEnum::IdrefList);
+
+PassOwnPtr<AXValueSource> createValueSource(NameSource&);
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698