Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1702643002: Don't report errors when SVG attributes are removed (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't report errors when SVG attributes are removed In some cases, SVGAnimated*, and the parser for the underlying object, will return an error when encountering a null String object (which it will be passed when the attribute it reflects is removed.) This can be misleading, so suppress error reporting in these cases. Also let SVGAnimatedViewBoxRect::setBaseValueAsString delegate to its superclass rather than open-coding the same thing. This could prove beneficial if adding additional logic for handling attribute removals. BUG=523685 Committed: https://crrev.com/a431d862bc9f2a936b31124a127a896f8cfa24f3 Cr-Commit-Position: refs/heads/master@{#375833}

Patch Set 1 #

Patch Set 2 : TEs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/dom/no-error-reporting-on-attribute-removal.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/dom/no-error-reporting-on-attribute-removal-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 10 months ago (2016-02-16 18:12:14 UTC) #2
Stephen Chennney
lgtm
4 years, 10 months ago (2016-02-16 18:22:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702643002/20001
4 years, 10 months ago (2016-02-17 08:51:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 08:56:57 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 08:59:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a431d862bc9f2a936b31124a127a896f8cfa24f3
Cr-Commit-Position: refs/heads/master@{#375833}

Powered by Google App Engine
This is Rietveld 408576698