third_party/WebKit/Source/core/svg/SVGElement.cpp - Issue 1702643002: Don't report errors when SVG attributes are removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 1702643002: Don't report errors when SVG attributes are removed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TEs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/dom/no-error-reporting-on-attribute-removal-expected.txt ('k') | third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp

index 5a55cf203e3dec6ec8cb9bca13e283d47afc1aa5..01122159d3d2539b4032827eb33e85ec7ebcba64 100644

--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp

@@ -188,6 +188,9 @@ void SVGElement::reportAttributeParsingError(SVGParsingError error, const Qualif

{

if (error == SVGParseStatus::NoError)

return;

+ // Don't report any errors on attribute removal.

+ if (value.isNull())

+ return;

document().accessSVGExtensions().reportError(error.format(tagName(), name, value));

}