Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 1702643002: Don't report errors when SVG attributes are removed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TEs Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 5 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 return false; 181 return false;
182 182
183 // This is true whenever this is the outermost SVG, even if there are HTML e lements outside it 183 // This is true whenever this is the outermost SVG, even if there are HTML e lements outside it
184 return !parentNode()->isSVGElement(); 184 return !parentNode()->isSVGElement();
185 } 185 }
186 186
187 void SVGElement::reportAttributeParsingError(SVGParsingError error, const Qualif iedName& name, const AtomicString& value) 187 void SVGElement::reportAttributeParsingError(SVGParsingError error, const Qualif iedName& name, const AtomicString& value)
188 { 188 {
189 if (error == SVGParseStatus::NoError) 189 if (error == SVGParseStatus::NoError)
190 return; 190 return;
191 // Don't report any errors on attribute removal.
192 if (value.isNull())
193 return;
191 document().accessSVGExtensions().reportError(error.format(tagName(), name, v alue)); 194 document().accessSVGExtensions().reportError(error.format(tagName(), name, v alue));
192 } 195 }
193 196
194 String SVGElement::title() const 197 String SVGElement::title() const
195 { 198 {
196 // According to spec, we should not return titles when hovering over root <s vg> elements (those 199 // According to spec, we should not return titles when hovering over root <s vg> elements (those
197 // <title> elements are the title of the document, not a tooltip) so we inst antly return. 200 // <title> elements are the title of the document, not a tooltip) so we inst antly return.
198 if (isOutermostSVGSVGElement()) 201 if (isOutermostSVGSVGElement())
199 return String(); 202 return String();
200 203
(...skipping 1017 matching lines...) Expand 10 before | Expand all | Expand 10 after
1218 Element::trace(visitor); 1221 Element::trace(visitor);
1219 } 1222 }
1220 1223
1221 const AtomicString& SVGElement::eventParameterName() 1224 const AtomicString& SVGElement::eventParameterName()
1222 { 1225 {
1223 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt", AtomicString::Con structFromLiteral)); 1226 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt", AtomicString::Con structFromLiteral));
1224 return evtString; 1227 return evtString;
1225 } 1228 }
1226 1229
1227 } // namespace blink 1230 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698