third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp - Issue 1702643002: Don't report errors when SVG attributes are removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

Issue 1702643002: Don't report errors when SVG attributes are removed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TEs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp b/third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

index a1664d0302f27d95a14fb0daae5c6fb3e07bcb63..5c20ee5768d6f8e4cbb76ec248d4284901de0198 100644

--- a/third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

@@ -49,7 +49,7 @@ protected:

SVGParsingError SVGAnimatedViewBoxRect::setBaseValueAsString(const String& value)

{

- SVGParsingError parseStatus = baseValue()->setValueAsString(value);

+ SVGParsingError parseStatus = SVGAnimatedRect::setBaseValueAsString(value);

if (parseStatus == SVGParseStatus::NoError && (baseValue()->width() < 0 || baseValue()->height() < 0)) {

parseStatus = SVGParseStatus::NegativeValue;

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.cpp ('k') | no next file » | no next file with comments »