Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
NOTRY=true

Committed: https://crrev.com/e91f8875e590ddf00af267062fc1a9ec48658373
Cr-Commit-Position: refs/heads/master@{#375953}

[Dan Beam, 2016-02-16 07:02:41]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-02-16 07:06:33]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2016-02-16 18:44:27]

Description was changed from

==========
BeautifulGYP

BUG=
==========

to

==========
Generate dependency graphs for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org
BUG=
==========

[dpapad, 2016-02-16 19:19:50]

Can we make the generated files output prettier? For example if it could match
the output at https://codereview.chromium.org/1695663004, I think this would be
very readable.

Also can we add a comment in the generated files to the effect of
"This file is auto-genarated from ..., do not edit manually".

[Dan Beam, 2016-02-16 19:20:59]

On 2016/02/16 19:19:50, dpapad wrote:
> Can we make the generated files output prettier? For example if it could match
> the output at https://codereview.chromium.org/1695663004, I think this would
be
> very readable.

do you anticipate reading generated files often?  why?

> 
> Also can we add a comment in the generated files to the effect of
> "This file is auto-genarated from ..., do not edit manually".

will do

[michaelpg, 2016-02-16 19:22:21]

I think the strategy is sound, minus the assumption that each *.html has an
associated *-extracted.js.

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
File
third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp
(right):

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp:13:
'target_name': 'demo-pages-extracted'},
this doesn't exist afaict

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
File third_party/polymer/v1_0/generate_gyp.sh (right):

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
third_party/polymer/v1_0/generate_gyp.sh:6: htmls=$(/bin/ls $dir/*.html
2>/dev/null | grep -v 'index\.html')
as a bash noob: why /bin/ls instead of \ls

[Dan Beam, 2016-02-16 21:04:28]

Patchset #3 (id:80001) has been deleted

[Dan Beam, 2016-02-16 21:04:34]

Patchset #2 (id:60001) has been deleted

[Dan Beam, 2016-02-16 21:05:49]

dbeam@chromium.org changed reviewers:
+ dpapad@chromium.org, michaelpg@chromium.org

[Dan Beam, 2016-02-16 21:05:50]

- filtered out demo.html
- checking for existence of -extracted.js files now
- changed formatting to look like existing compiled_resources2.gyp files

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
File
third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp
(right):

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp:13:
'target_name': 'demo-pages-extracted'},
On 2016/02/16 19:22:21, michaelpg wrote:
> this doesn't exist afaict

filtered out demo.html files and checking for an -extracted.js in the file
system

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
File third_party/polymer/v1_0/generate_gyp.sh (right):

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
third_party/polymer/v1_0/generate_gyp.sh:6: htmls=$(/bin/ls $dir/*.html
2>/dev/null | grep -v 'index\.html')
On 2016/02/16 19:22:21, michaelpg wrote:
> as a bash noob: why /bin/ls instead of \ls

/bin/ls because many people alias the `ls` command

[dpapad, 2016-02-16 22:10:32]

On 2016/02/16 at 19:19:50, dpapad wrote:
> Can we make the generated files output prettier? For example if it could match
the output at https://codereview.chromium.org/1695663004, I think this would be
very readable.
> 
> Also can we add a comment in the generated files to the effect of
> "This file is auto-genarated from ..., do not edit manually".

Other than ^, LGTM

[dpapad, 2016-02-16 22:12:05]

On 2016/02/16 at 22:10:32, dpapad wrote:
> On 2016/02/16 at 19:19:50, dpapad wrote:
> > Can we make the generated files output prettier? For example if it could
match the output at https://codereview.chromium.org/1695663004, I think this
would be very readable.
> > 
> > Also can we add a comment in the generated files to the effect of
> > "This file is auto-genarated from ..., do not edit manually".
> 
> Other than ^, LGTM

And also at least https://codereview.chromium.org/1695663004 (Node version of
the same script), forced you to write the python version, so I contributed to
this in some indirect way ;>

[Dan Beam, 2016-02-16 22:24:22]

On 2016/02/16 22:12:05, dpapad wrote:
> On 2016/02/16 at 22:10:32, dpapad wrote:
> > On 2016/02/16 at 19:19:50, dpapad wrote:
> > > Can we make the generated files output prettier? For example if it could
> match the output at https://codereview.chromium.org/1695663004, I think this
> would be very readable.
> > > 
> > > Also can we add a comment in the generated files to the effect of
> > > "This file is auto-genarated from ..., do not edit manually".
> > 
> > Other than ^, LGTM
> 
> And also at least https://codereview.chromium.org/1695663004 (Node version of
> the same script), forced you to write the python version, so I contributed to
> this in some indirect way ;>

watching others write parsers in regex and forever pay the costs (as I have with
various presubmits) is very inspiring, yes ;)

[Dan Beam, 2016-02-16 23:18:41]

Description was changed from

==========
Generate dependency graphs for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org
BUG=
==========

to

==========
Generate dependency graphs for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
==========

[Dan Beam, 2016-02-16 23:46:12]

+michaelpg@ for tools/polymer

[michaelpg, 2016-02-17 06:26:48]

lgtm

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
File third_party/polymer/v1_0/generate_gyp.sh (right):

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
third_party/polymer/v1_0/generate_gyp.sh:6: htmls=$(/bin/ls $dir/*.html
2>/dev/null | grep -v 'index\.html')
On 2016/02/16 21:05:50, Dan Beam wrote:
> On 2016/02/16 19:22:21, michaelpg wrote:
> > as a bash noob: why /bin/ls instead of \ls
> 
> /bin/ls because many people alias the `ls` command

ya but that's why you use \ls

$ alias ls='sudo rm -rf /'
$ \ls
bin boot dev etc

(also you're invoking this as a script so aliases won't work anyway)

https://codereview.chromium.org/1702553002/diff/160001/third_party/polymer/v1...
File third_party/polymer/v1_0/reproduce.sh (right):

https://codereview.chromium.org/1702553002/diff/160001/third_party/polymer/v1...
third_party/polymer/v1_0/reproduce.sh:25: check_dep "python -c 'import bs4'"
"bs4" "apt-get install python-bs4"
oh, i guess that answers my question about eval.

[Dan Beam, 2016-02-17 17:23:11]

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
File third_party/polymer/v1_0/generate_gyp.sh (right):

https://codereview.chromium.org/1702553002/diff/40001/third_party/polymer/v1_...
third_party/polymer/v1_0/generate_gyp.sh:6: htmls=$(/bin/ls $dir/*.html
2>/dev/null | grep -v 'index\.html')
On 2016/02/17 06:26:48, michaelpg wrote:
> On 2016/02/16 21:05:50, Dan Beam wrote:
> > On 2016/02/16 19:22:21, michaelpg wrote:
> > > as a bash noob: why /bin/ls instead of \ls
> > 
> > /bin/ls because many people alias the `ls` command
> 
> ya but that's why you use \ls
> 
> $ alias ls='sudo rm -rf /'
> $ \ls
> bin boot dev etc
> 
> (also you're invoking this as a script so aliases won't work anyway)

Done.

https://codereview.chromium.org/1702553002/diff/160001/third_party/polymer/v1...
File third_party/polymer/v1_0/reproduce.sh (right):

https://codereview.chromium.org/1702553002/diff/160001/third_party/polymer/v1...
third_party/polymer/v1_0/reproduce.sh:25: check_dep "python -c 'import bs4'"
"bs4" "apt-get install python-bs4"
On 2016/02/17 06:26:48, michaelpg wrote:
> oh, i guess that answers my question about eval.

yep

[Dan Beam, 2016-02-17 17:49:57]

Description was changed from

==========
Generate dependency graphs for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
==========

to

==========
Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
==========

[Dan Beam, 2016-02-17 17:50:43]

Description was changed from

==========
Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
==========

to

==========
Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
NOTRY=true
==========

[Dan Beam, 2016-02-17 19:27:30]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-02-17 19:27:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org,
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1702553002/#ps180001
(title: "\ls")

[commit-bot: I haz the power, 2016-02-17 19:28:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702553002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702553002/180001

[commit-bot: I haz the power, 2016-02-17 19:41:19]

Description was changed from

==========
Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
NOTRY=true
==========

to

==========
Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
NOTRY=true
==========

[commit-bot: I haz the power, 2016-02-17 19:41:20]

Committed patchset #6 (id:180001)

[commit-bot: I haz the power, 2016-02-17 19:43:42]

Description was changed from

==========
Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
NOTRY=true
==========

to

==========
Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

This CL aims to generate GYP output from the imports listed
in each HTML file in Polymer to Closure Compile the code.

R=dpapad@chromium.org,michaelpg@chromium.org
BUG=none
NOTRY=true

Committed: https://crrev.com/e91f8875e590ddf00af267062fc1a9ec48658373
Cr-Commit-Position: refs/heads/master@{#375953}
==========

[commit-bot: I haz the power, 2016-02-17 19:43:43]

Patchset 6 (id:??) landed as
https://crrev.com/e91f8875e590ddf00af267062fc1a9ec48658373
Cr-Commit-Position: refs/heads/master@{#375953}

[sky, 2016-02-17 20:36:42]

A revert of this CL (patchset #6 id:180001) has been created in
https://codereview.chromium.org/1705953002/ by sky@chromium.org.

The reason for reverting is: This broke checklicenses:
'third_party/polymer/v1_0/generate_gyp.sh' has non-whitelisted license 'UNKNOWN'
.