third_party/polymer/v1_0/generate_gyp.sh - Issue 1702553002: Generate compiled_resources2.gyp for Polymer based on <link rel=import>s

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/polymer/v1_0/generate_gyp.sh

Issue 1702553002: Generate compiled_resources2.gyp for Polymer based on <link rel=import>s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asdf Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp ('K') | « third_party/polymer/v1_0/components-chromium/paper-tooltip/compiled_resources2.gyp ('k') | tools/polymer/generate_compiled_resources_gypi.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 #!/bin/sh

	2

	3 dirs=$(find components-chromium -type d \| grep -v 'components-chromium/polymer')

	4

	5 for dir in $dirs; do

	6 htmls=$(/bin/ls $dir/*.html 2>/dev/null \| grep -v 'index\.html')
	michaelpg 2016/02/16 19:22:21 as a bash noob: why /bin/ls instead of \ls as a bash noob: why /bin/ls instead of \ls Dan Beam 2016/02/16 21:05:50 /bin/ls because many people alias the `ls` command Show quoted text On 2016/02/16 19:22:21, michaelpg wrote: > as a bash noob: why /bin/ls instead of \ls /bin/ls because many people alias the `ls` command michaelpg 2016/02/17 06:26:48 ya but that's why you use \ls $ alias ls='sudo rm Show quoted text On 2016/02/16 21:05:50, Dan Beam wrote: > On 2016/02/16 19:22:21, michaelpg wrote: > > as a bash noob: why /bin/ls instead of \ls > > /bin/ls because many people alias the `ls` command ya but that's why you use \ls $ alias ls='sudo rm -rf /' $ \ls bin boot dev etc (also you're invoking this as a script so aliases won't work anyway) Dan Beam 2016/02/17 17:23:11 Done. Show quoted text On 2016/02/17 06:26:48, michaelpg wrote: > On 2016/02/16 21:05:50, Dan Beam wrote: > > On 2016/02/16 19:22:21, michaelpg wrote: > > > as a bash noob: why /bin/ls instead of \ls > > > > /bin/ls because many people alias the `ls` command > > ya but that's why you use \ls > > $ alias ls='sudo rm -rf /' > $ \ls > bin boot dev etc > > (also you're invoking this as a script so aliases won't work anyway) Done.
	7 if [ "$htmls" ]; then

	8 echo "Generating GYP for $dir"

	9 ../../../tools/polymer/generate_compiled_resources_gypi.py $htmls > \

	10 "$dir/compiled_resources2.gyp"

	11 fi

	12 done

OLD	NEW