Polymer: make reproduce.sh check for tools it depends on

Polymer: make reproduce.sh check for tools it depends on

R=michaelpg@chromium.org
BUG=none
NOTRY=true

Committed: https://crrev.com/0b776087ad4208163d9df9f4065f4979b2e19beb
Cr-Commit-Position: refs/heads/master@{#375916}

[Dan Beam, 2016-02-17 03:59:54]

Description was changed from

==========
Polymer: make reproduce.sh check for dependencies

R=michaelpg@chromium.org
BUG=none
==========

to

==========
Polymer: make reproduce.sh check for tools it depends on

R=michaelpg@chromium.org
BUG=none
==========

[michaelpg, 2016-02-17 05:14:29]

lgtm

https://codereview.chromium.org/1702833002/diff/20001/third_party/polymer/v1_...
File third_party/polymer/v1_0/reproduce.sh (right):

https://codereview.chromium.org/1702833002/diff/20001/third_party/polymer/v1_...
third_party/polymer/v1_0/reproduce.sh:13: eval "$1" >/dev/null 2>&1
why: eval "$1"
why not: which "$2"

[Dan Beam, 2016-02-17 17:22:31]

https://codereview.chromium.org/1702833002/diff/20001/third_party/polymer/v1_...
File third_party/polymer/v1_0/reproduce.sh (right):

https://codereview.chromium.org/1702833002/diff/20001/third_party/polymer/v1_...
third_party/polymer/v1_0/reproduce.sh:13: eval "$1" >/dev/null 2>&1
On 2016/02/17 05:14:29, michaelpg wrote:
> why: eval "$1"
> why not: which "$2"

https://codereview.chromium.org/1702553002/diff/160001/third_party/polymer/v1...

as you found

[Dan Beam, 2016-02-17 17:22:40]

Description was changed from

==========
Polymer: make reproduce.sh check for tools it depends on

R=michaelpg@chromium.org
BUG=none
==========

to

==========
Polymer: make reproduce.sh check for tools it depends on

R=michaelpg@chromium.org
BUG=none
NOTRY=true
==========

[Dan Beam, 2016-02-17 17:23:07]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-02-17 17:25:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702833002/20001

[commit-bot: I haz the power, 2016-02-17 17:35:04]

Description was changed from

==========
Polymer: make reproduce.sh check for tools it depends on

R=michaelpg@chromium.org
BUG=none
NOTRY=true
==========

to

==========
Polymer: make reproduce.sh check for tools it depends on

R=michaelpg@chromium.org
BUG=none
NOTRY=true
==========

[commit-bot: I haz the power, 2016-02-17 17:35:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-17 17:36:14]

Description was changed from

==========
Polymer: make reproduce.sh check for tools it depends on

R=michaelpg@chromium.org
BUG=none
NOTRY=true
==========

to

==========
Polymer: make reproduce.sh check for tools it depends on

R=michaelpg@chromium.org
BUG=none
NOTRY=true

Committed: https://crrev.com/0b776087ad4208163d9df9f4065f4979b2e19beb
Cr-Commit-Position: refs/heads/master@{#375916}
==========

[commit-bot: I haz the power, 2016-02-17 17:36:16]

Patchset 2 (id:??) landed as
https://crrev.com/0b776087ad4208163d9df9f4065f4979b2e19beb
Cr-Commit-Position: refs/heads/master@{#375916}