Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1695663004: Adding GYP V2 targets for all Polymer code (with a script!).

Created:
4 years, 10 months ago by dpapad
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews, dcheng, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding GYP V2 targets for all Polymer code (with a script!). ... a nodeJS script... see gendeps.js. BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding JSDoc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1761 lines, -84 lines) Patch
A + third_party/polymer/v1_0/components-chromium/font-roboto/compiled_resources2.gyp View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/compiled_resources2.gyp View 1 chunk +6 lines, -4 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-a11y-keys/compiled_resources2.gyp View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/compiled_resources2.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/compiled_resources2.gyp View 1 chunk +10 lines, -5 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/compiled_resources2.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-collapse/compiled_resources2.gyp View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp View 1 chunk +31 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-fit-behavior/compiled_resources2.gyp View 1 chunk +7 lines, -5 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-flex-layout/compiled_resources2.gyp View 1 chunk +28 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-form-element-behavior/compiled_resources2.gyp View 1 chunk +7 lines, -5 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-icon/compiled_resources2.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-icons/compiled_resources2.gyp View 1 chunk +117 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-iconset-svg/compiled_resources2.gyp View 1 chunk +8 lines, -6 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-image/compiled_resources2.gyp View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-input/compiled_resources2.gyp View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/compiled_resources2.gyp View 1 chunk +8 lines, -6 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-media-query/compiled_resources2.gyp View 1 chunk +7 lines, -5 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-menu-behavior/compiled_resources2.gyp View 1 chunk +26 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-meta/compiled_resources2.gyp View 1 chunk +7 lines, -5 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/compiled_resources2.gyp View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-pages/compiled_resources2.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-range-behavior/compiled_resources2.gyp View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/compiled_resources2.gyp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-scroll-target-behavior/compiled_resources2.gyp View 1 chunk +6 lines, -4 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-selector/compiled_resources2.gyp View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-test-helpers/compiled_resources2.gyp View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-validatable-behavior/compiled_resources2.gyp View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/neon-animation/compiled_resources2.gyp View 1 chunk +303 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-behaviors/compiled_resources2.gyp View 1 chunk +31 lines, -9 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-button/compiled_resources2.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-card/compiled_resources2.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-checkbox/compiled_resources2.gyp View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/compiled_resources2.gyp View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dialog/compiled_resources2.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-drawer-panel/compiled_resources2.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/compiled_resources2.gyp View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-fab/compiled_resources2.gyp View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-header-panel/compiled_resources2.gyp View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-icon-button/compiled_resources2.gyp View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-input/compiled_resources2.gyp View 1 chunk +93 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-item/compiled_resources2.gyp View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-material/compiled_resources2.gyp View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-menu-button/compiled_resources2.gyp View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-menu/compiled_resources2.gyp View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-progress/compiled_resources2.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-radio-button/compiled_resources2.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/paper-radio-group/compiled_resources2.gyp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/compiled_resources2.gyp View 1 chunk +9 lines, -7 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-slider/compiled_resources2.gyp View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-spinner/compiled_resources2.gyp View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-styles/compiled_resources2.gyp View 1 chunk +101 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-tabs/compiled_resources2.gyp View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-toggle-button/compiled_resources2.gyp View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-toolbar/compiled_resources2.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/paper-tooltip/compiled_resources2.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/gendeps.js View 1 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Dan Beam
https://codereview.chromium.org/1695663004/diff/1/third_party/polymer/v1_0/gendeps.js File third_party/polymer/v1_0/gendeps.js (right): https://codereview.chromium.org/1695663004/diff/1/third_party/polymer/v1_0/gendeps.js#newcode39 third_party/polymer/v1_0/gendeps.js:39: var regexp = /^<link rel="import" href="(.*)"/; BeautifulSoup is a ...
4 years, 10 months ago (2016-02-16 07:01:08 UTC) #2
dpapad
4 years, 10 months ago (2016-02-16 18:59:16 UTC) #3
On 2016/02/16 at 07:01:08, dbeam wrote:
>
https://codereview.chromium.org/1695663004/diff/1/third_party/polymer/v1_0/ge...
> File third_party/polymer/v1_0/gendeps.js (right):
> 
>
https://codereview.chromium.org/1695663004/diff/1/third_party/polymer/v1_0/ge...
> third_party/polymer/v1_0/gendeps.js:39: var regexp = /^<link rel="import"
href="(.*)"/;
> BeautifulSoup is a better candidate for this, IMO:
> https://codereview.chromium.org/1702553002/

Tried to keep third-party Node dependencies to a minimum (currently only using
"glob"). There are a few HTML
parsers for Node too, (cheerio, and port of BeautifulSoup node-soupselect), but
the regexp seems to be good
enough, no need to fully parse the file to extract it.

Either way would you be OK if I remove the gendeps.js script from this CL and
land the compiled_resources2.gyp files?
We can decide separately about how to move forward with the script (node vs
python, and which 3rd party deps).

Powered by Google App Engine
This is Rietveld 408576698