Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1701813002: Make Keyframe::PropertySpecificKeyframes RefCounted (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Keyframe::PropertySpecificKeyframes RefCounted This change adds ref counting to Keyframe::PropertySpecificKeyframe. This refactor is in preparation for https://codereview.chromium.org/1698093005 which requires multiple owners of a PropertySpecificKeyframe. This patch introduces no change in behaviour. BUG=360473 Committed: https://crrev.com/15e4e37b0f1046bfa45646b5336805aef062bb14 Cr-Commit-Position: refs/heads/master@{#375813}

Patch Set 1 #

Patch Set 2 : InvalidatableInterpolation RefPtrs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -95 lines) Patch
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Keyframe.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectModel.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.h View 4 chunks +21 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 3 chunks +16 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h View 2 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp View 2 chunks +6 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2016-02-17 00:02:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701813002/20001
4 years, 10 months ago (2016-02-17 01:17:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 02:24:43 UTC) #7
Eric Willigers
lgtm
4 years, 10 months ago (2016-02-17 06:20:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701813002/20001
4 years, 10 months ago (2016-02-17 06:35:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 06:40:59 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 06:42:09 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15e4e37b0f1046bfa45646b5336805aef062bb14
Cr-Commit-Position: refs/heads/master@{#375813}

Powered by Google App Engine
This is Rietveld 408576698