third_party/WebKit/Source/core/animation/KeyframeEffectModel.h - Issue 1701813002: Make Keyframe::PropertySpecificKeyframes RefCounted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectModel.h

Issue 1701813002: Make Keyframe::PropertySpecificKeyframes RefCounted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: InvalidatableInterpolation RefPtrs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/Keyframe.h ('k') | third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffectModel.h

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h b/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h

index 6ab174b55af09d80569a99e56f10cbc2171691fa..895e22ddee2975ed5c2590d2a26fd423ed0d2fbf 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h

@@ -42,7 +42,6 @@

#include "platform/heap/Handle.h"

#include "wtf/HashMap.h"

#include "wtf/HashSet.h"

-#include "wtf/PassOwnPtr.h"

#include "wtf/PassRefPtr.h"

#include "wtf/Vector.h"

@@ -55,10 +54,10 @@ class CORE_EXPORT KeyframeEffectModelBase : public EffectModel {

public:

// FIXME: Implement accumulation.

- using PropertySpecificKeyframeVector = Vector<OwnPtr<Keyframe::PropertySpecificKeyframe>>;

+ using PropertySpecificKeyframeVector = Vector<RefPtr<Keyframe::PropertySpecificKeyframe>>;

class PropertySpecificKeyframeGroup {

public:

- void appendKeyframe(PassOwnPtr<Keyframe::PropertySpecificKeyframe>);

+ void appendKeyframe(PassRefPtr<Keyframe::PropertySpecificKeyframe>);

const PropertySpecificKeyframeVector& keyframes() const { return m_keyframes; }

private: