Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1698093005: Discard SampledEffects on elements if they are redundant (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_renameToSampledEffect
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Discard SampledEffects on elements if they are redundant This change is a memory performance optimisation to discard SampledEffects that will never change [0] and have their effects occluded by other SampledEffects that will never change. [0] https://docs.google.com/document/d/1NomOWRrGQHlynQGO64CgdqRPAAEHhi3fSa8sf0Ip6xE BUG=360473 Committed: https://crrev.com/4dd3920845f5f628f606909cdb447e6576fd4292 Cr-Commit-Position: refs/heads/master@{#375877}

Patch Set 1 #

Patch Set 2 : New dependency #

Patch Set 3 : Rebased #

Messages

Total messages: 20 (10 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2016-02-16 06:43:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698093005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698093005/20001
4 years, 10 months ago (2016-02-17 01:17:38 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/181945)
4 years, 10 months ago (2016-02-17 02:36:28 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698093005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698093005/40001
4 years, 10 months ago (2016-02-17 05:44:27 UTC) #11
Timothy Loh
lgmt
4 years, 10 months ago (2016-02-17 06:27:35 UTC) #12
Timothy Loh
On 2016/02/17 06:27:35, Timothy Loh wrote: > lgmt lgtm
4 years, 10 months ago (2016-02-17 06:29:51 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 06:52:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698093005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698093005/40001
4 years, 10 months ago (2016-02-17 14:10:33 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-17 14:17:04 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 14:18:34 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4dd3920845f5f628f606909cdb447e6576fd4292
Cr-Commit-Position: refs/heads/master@{#375877}

Powered by Google App Engine
This is Rietveld 408576698