Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1701853002: Code clean up: Rename SampledEffect variables to sampledEffect instead of effect (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_refCountPSKs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Code clean up: Rename SampledEffect variables to sampledEffect instead of effect SampledEffects and AnimationEffects are dealt with in the same area of code. Renaming references to SampledEffects as sampledEffect instead of effect helps disambiguate the code. This patch introduces no change in behaviour. This clean up is in preparation for: https://codereview.chromium.org/1698093005 Committed: https://crrev.com/7f28ada410ba34bb834907c895ab62282dab8d59 Cr-Commit-Position: refs/heads/master@{#375819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationStack.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStack.cpp View 4 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStackTest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2016-02-16 23:59:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701853002/1
4 years, 10 months ago (2016-02-17 01:17:41 UTC) #5
Eric Willigers
lgtm
4 years, 10 months ago (2016-02-17 01:51:55 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/174691)
4 years, 10 months ago (2016-02-17 03:17:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701853002/1
4 years, 10 months ago (2016-02-17 06:46:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 07:54:49 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 07:55:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f28ada410ba34bb834907c895ab62282dab8d59
Cr-Commit-Position: refs/heads/master@{#375819}

Powered by Google App Engine
This is Rietveld 408576698