Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.

Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide.  Hence the "Holder" name.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/32c70815316672091946be88e5941089c359d151

[Tom Sepez, 2016-02-16 18:57:59]

Description was changed from

==========
Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't wan to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.
==========

to

==========
Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.
==========

[Tom Sepez, 2016-02-16 19:01:31]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-16 19:01:31]

Lei, for review.  Next part of the ptr_list work that I'm trying to split into
small pieces ...

[Tom Sepez, 2016-02-16 19:02:18]

Description was changed from

==========
Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.
==========

to

==========
Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.

Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide.
==========

[Tom Sepez, 2016-02-16 20:10:06]

Description was changed from

==========
Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.

Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide.
==========

to

==========
Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.

Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide.  Hence the "Holder" name.
==========

[Lei Zhang, 2016-02-17 00:28:59]

lgtm

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_module.h (right):

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_module.h:27: class CPDF_PageObjectHolder;
Not needed.

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_page.h (right):

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_page.h:32: CPDF_PageObjectList(int nBlockSize) :
CFX_PtrList(nBlockSize) {}
explicit

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdftext/f...
File core/include/fpdftext/fpdf_text.h (right):

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdftext/f...
core/include/fpdftext/fpdf_text.h:13: class CPDF_PageObjectHolder;
Not needed.

https://codereview.chromium.org/1701073002/diff/40001/core/src/fpdftext/text_...
File core/src/fpdftext/text_int.h (right):

https://codereview.chromium.org/1701073002/diff/40001/core/src/fpdftext/text_...
core/src/fpdftext/text_int.h:135: const CPDF_PageObjectHolder* const
m_pPageObjectHolder;
Can this be const CPDF_Page* const to avoid some of the casting in
fpdf_text_int.cpp?

[Tom Sepez, 2016-02-17 00:59:45]

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_module.h (right):

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_module.h:27: class CPDF_PageObjectHolder;
On 2016/02/17 00:28:59, Lei Zhang wrote:
> Not needed.

Done.

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_page.h (right):

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_page.h:32: CPDF_PageObjectList(int nBlockSize) :
CFX_PtrList(nBlockSize) {}
On 2016/02/17 00:28:59, Lei Zhang wrote:
> explicit

Done.

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdftext/f...
File core/include/fpdftext/fpdf_text.h (right):

https://codereview.chromium.org/1701073002/diff/40001/core/include/fpdftext/f...
core/include/fpdftext/fpdf_text.h:13: class CPDF_PageObjectHolder;
On 2016/02/17 00:28:59, Lei Zhang wrote:
> Not needed.

Done.

https://codereview.chromium.org/1701073002/diff/40001/core/src/fpdftext/text_...
File core/src/fpdftext/text_int.h (right):

https://codereview.chromium.org/1701073002/diff/40001/core/src/fpdftext/text_...
core/src/fpdftext/text_int.h:135: const CPDF_PageObjectHolder* const
m_pPageObjectHolder;
On 2016/02/17 00:28:59, Lei Zhang wrote:
> Can this be const CPDF_Page* const to avoid some of the casting in
> fpdf_text_int.cpp?

Good idea.  The ctor is only called with a page, not a form, so we don't need
the common superclass.

[Tom Sepez, 2016-02-17 01:15:36]

Description was changed from

==========
Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.

Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide.  Hence the "Holder" name.
==========

to

==========
Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.

Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide.  Hence the "Holder" name.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/32c70815316672091946be88e5941089c359...
==========

[Tom Sepez, 2016-02-17 01:15:37]

Committed patchset #5 (id:80001) manually as
32c70815316672091946be88e5941089c359d151 (presubmit successful).