core/src/fpdfapi/fpdf_font/fpdf_font.cpp - Issue 1701073002: Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/fpdf_font.cpp

Issue 1701073002: Split CPDF_PageObjectHolder off from CPDF_PageObjectList (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: m_pPage can never be null, remove checks. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/fpdf_font.cpp

diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

index e3d75076d7d8713dcd1d405fe17359963433f5b4..ec86a60d6fd93f8d54f11a885108ffb11fe328e9 100644

--- a/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

+++ b/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

@@ -1706,7 +1706,7 @@ CPDF_Type3Char* CPDF_Type3Font::LoadChar(FX_DWORD charcode, int level) {

ASSERT(!pdfium::ContainsKey(m_CacheMap, charcode));

CPDF_Type3Char* pCachedChar = pNewChar.release();

m_CacheMap[charcode] = pCachedChar;

- if (pCachedChar->m_pForm->CountObjects() == 0) {

+ if (pCachedChar->m_pForm->GetPageObjectList()->GetCount() == 0) {

delete pCachedChar->m_pForm;

pCachedChar->m_pForm = nullptr;

}