core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp - Issue 1701073002: Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

Issue 1701073002: Split CPDF_PageObjectHolder off from CPDF_PageObjectList (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: m_pPage can never be null, remove checks. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

index 20345138b422cebc5196b6107d5b194a6c2ced23..a003d2047fda1eadfb128d90b0f3937f9adccdf2 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

@@ -520,7 +520,7 @@ void CPDF_AllStates::ProcessExtGS(CPDF_Dictionary* pGS,

pGeneralState->SetBlendMode(mode);

if (pGeneralState->m_BlendType > FXDIB_BLEND_MULTIPLY) {

- pParser->GetObjectList()->SetBackgroundAlphaNeeded(TRUE);

+ pParser->GetPageObjectHolder()->SetBackgroundAlphaNeeded(TRUE);

}

break;

}