core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp - Issue 1701073002: Split CPDF_PageObjectHolder off from CPDF_PageObjectList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

Issue 1701073002: Split CPDF_PageObjectHolder off from CPDF_PageObjectList (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: m_pPage can never be null, remove checks. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

index 022c170bf0af84e412c16cbd692b98c0b0e720af..7fa3286e1172388c12d3379a044e70ffde3a6ef5 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

@@ -841,10 +841,10 @@ void CPDF_ContentParser::Continue(IFX_Pause* pPause) {

m_pType3Char->m_BBox.top =

FXSYS_round(m_pParser->GetType3Data()[5] * 1000);

}

- FX_POSITION pos = m_pObjects->GetFirstObjectPosition();

+ FX_POSITION pos = m_pObjects->GetPageObjectList()->GetHeadPosition();

while (pos) {

CPDF_PageObject* pObj =

- (CPDF_PageObject*)m_pObjects->GetNextObject(pos);

+ m_pObjects->GetPageObjectList()->GetNextObject(pos);

if (pObj->m_ClipPath.IsNull()) {

continue;

}