Issue 17010003: Cleanup of system settings constants (ab)use.

Issue 17010003: Cleanup of system settings constants (ab)use. (Closed)

Created:
7 years, 6 months ago by zel

Modified:
7 years, 6 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tbarzic+watch_chromium.org, tfarina, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup of system settings constants (ab)use. BUG=none TEST=existing unit/browser tests TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207230

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -53 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/customization_document.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/echo_private_api.cc	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/info_private_api.cc	View	1 2 3 4	4 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/imageburner/burn_manager.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/hwid_checker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_display_host_impl.cc	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/policy/device_status_collector.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/system/statistics_provider.h	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/system/statistics_provider.cc	View	1 2	2 chunks	+20 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/scoped_gaia_auth_extension.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate_chromeos.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/proxy_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/chromeos_constants.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chromeos/chromeos_constants.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

xiyuan

lgtm https://codereview.chromium.org/17010003/diff/1001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc (right): https://codereview.chromium.org/17010003/diff/1001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc#newcode2266 chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc:2266: board); nit: Does this fit in one line? ...

7 years, 6 months ago (2013-06-18 04:59:23 UTC) #2

zel

https://codereview.chromium.org/17010003/diff/1001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc (right): https://codereview.chromium.org/17010003/diff/1001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc#newcode2266 chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc:2266: board); On 2013/06/18 04:59:23, xiyuan wrote: > nit: Does ...

7 years, 6 months ago (2013-06-18 17:56:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/17010003/12001

7 years, 6 months ago (2013-06-18 18:08:33 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=165297

7 years, 6 months ago (2013-06-18 21:43:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/17010003/33001

7 years, 6 months ago (2013-06-18 23:26:30 UTC) #6

Message was sent while issue was closed.

Change committed as 207230

Expand Messages | Collapse Messages