Cleanup of system settings constants (ab)use.

chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h"
 
 #include <sys/stat.h>
 #include <sys/statvfs.h>
 #include <sys/types.h>
 #include <utime.h>
@@ skipping 2237 matching lines @@
       drive::DriveIntegrationServiceFactory::GetForProfile(profile_);
   dict->SetBoolean("ENABLE_GDATA", integration_service != NULL);
 
 #if defined(USE_ASH)
   dict->SetBoolean("ASH", true);
 #else
   dict->SetBoolean("ASH", false);
 #endif
 
   std::string board;
-  const char kMachineInfoBoard[] = "CHROMEOS_RELEASE_BOARD";
   chromeos::system::StatisticsProvider* provider =
       chromeos::system::StatisticsProvider::GetInstance();
-  if (!provider->GetMachineStatistic(kMachineInfoBoard, &board))
+  if (!provider->GetMachineStatistic(
+          chromeos::system::kMachineInfoBoard,
+          &board)) {
     board = "unknown";
-  dict->SetString(kMachineInfoBoard, board);
+  }
+  dict->SetString(chromeos::system::kMachineInfoBoard,
+                  board);

[xiyuan, 2013/06/18 04:59:23]

nit: Does this fit in one line?

[zel, 2013/06/18 17:56:37]

Done.

 
   return true;
 }
 
 GetDriveEntryPropertiesFunction::GetDriveEntryPropertiesFunction() {
 }
 
 GetDriveEntryPropertiesFunction::~GetDriveEntryPropertiesFunction() {
 }
 
@@ skipping 806 matching lines @@
 OpenNewWindowFunction::OpenNewWindowFunction() {}
 
 OpenNewWindowFunction::~OpenNewWindowFunction() {}
 
 bool OpenNewWindowFunction::RunImpl() {
   std::string url;
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &url));
   file_manager_util::OpenNewWindow(profile_, GURL(url));
   return true;
 }