Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc

Issue 17010003: Cleanup of system settings constants (ab)use. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_private_a pi.h" 5 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_private_a pi.h"
6 6
7 #include <sys/stat.h> 7 #include <sys/stat.h>
8 #include <sys/statvfs.h> 8 #include <sys/statvfs.h>
9 #include <sys/types.h> 9 #include <sys/types.h>
10 #include <utime.h> 10 #include <utime.h>
(...skipping 2237 matching lines...) Expand 10 before | Expand all | Expand 10 after
2248 drive::DriveIntegrationServiceFactory::GetForProfile(profile_); 2248 drive::DriveIntegrationServiceFactory::GetForProfile(profile_);
2249 dict->SetBoolean("ENABLE_GDATA", integration_service != NULL); 2249 dict->SetBoolean("ENABLE_GDATA", integration_service != NULL);
2250 2250
2251 #if defined(USE_ASH) 2251 #if defined(USE_ASH)
2252 dict->SetBoolean("ASH", true); 2252 dict->SetBoolean("ASH", true);
2253 #else 2253 #else
2254 dict->SetBoolean("ASH", false); 2254 dict->SetBoolean("ASH", false);
2255 #endif 2255 #endif
2256 2256
2257 std::string board; 2257 std::string board;
2258 const char kMachineInfoBoard[] = "CHROMEOS_RELEASE_BOARD";
2259 chromeos::system::StatisticsProvider* provider = 2258 chromeos::system::StatisticsProvider* provider =
2260 chromeos::system::StatisticsProvider::GetInstance(); 2259 chromeos::system::StatisticsProvider::GetInstance();
2261 if (!provider->GetMachineStatistic(kMachineInfoBoard, &board)) 2260 if (!provider->GetMachineStatistic(chromeos::system::kMachineInfoBoard,
2261 &board)) {
2262 board = "unknown"; 2262 board = "unknown";
2263 dict->SetString(kMachineInfoBoard, board); 2263 }
2264 2264 dict->SetString(chromeos::system::kMachineInfoBoard, board);
2265 return true; 2265 return true;
2266 } 2266 }
2267 2267
2268 GetDriveEntryPropertiesFunction::GetDriveEntryPropertiesFunction() { 2268 GetDriveEntryPropertiesFunction::GetDriveEntryPropertiesFunction() {
2269 } 2269 }
2270 2270
2271 GetDriveEntryPropertiesFunction::~GetDriveEntryPropertiesFunction() { 2271 GetDriveEntryPropertiesFunction::~GetDriveEntryPropertiesFunction() {
2272 } 2272 }
2273 2273
2274 bool GetDriveEntryPropertiesFunction::RunImpl() { 2274 bool GetDriveEntryPropertiesFunction::RunImpl() {
(...skipping 805 matching lines...) Expand 10 before | Expand all | Expand 10 after
3080 OpenNewWindowFunction::OpenNewWindowFunction() {} 3080 OpenNewWindowFunction::OpenNewWindowFunction() {}
3081 3081
3082 OpenNewWindowFunction::~OpenNewWindowFunction() {} 3082 OpenNewWindowFunction::~OpenNewWindowFunction() {}
3083 3083
3084 bool OpenNewWindowFunction::RunImpl() { 3084 bool OpenNewWindowFunction::RunImpl() {
3085 std::string url; 3085 std::string url;
3086 EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &url)); 3086 EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &url));
3087 file_manager_util::OpenNewWindow(profile_, GURL(url)); 3087 file_manager_util::OpenNewWindow(profile_, GURL(url));
3088 return true; 3088 return true;
3089 } 3089 }
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/extensions/echo_private_api.cc ('k') | chrome/browser/chromeos/extensions/info_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698