Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2649)

Unified Diff: chrome/browser/chromeos/extensions/info_private_api.cc

Issue 17010003: Cleanup of system settings constants (ab)use. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/info_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/info_private_api.cc b/chrome/browser/chromeos/extensions/info_private_api.cc
index 872d7902814dac34dfa228401ecd752ada86c1d2..8bd78aa87b5242988cc11df12df3fbec164451e9 100644
--- a/chrome/browser/chromeos/extensions/info_private_api.cc
+++ b/chrome/browser/chromeos/extensions/info_private_api.cc
@@ -18,9 +18,6 @@ namespace extensions {
namespace {
-// Name of machine statistic property with HWID.
-const char kHardwareClass[] = "hardware_class";
-
// Key which corresponds to the HWID setting.
const char kPropertyHWID[] = "hwid";
@@ -30,9 +27,6 @@ const char kPropertyHomeProvider[] = "homeProvider";
// Key which corresponds to the initial_locale property.
const char kPropertyInitialLocale[] = "initialLocale";
-// Name of machine statistic property with board.
-const char kPropertyReleaseBoard[] = "CHROMEOS_RELEASE_BOARD";
-
// Key which corresponds to the board property in JS.
const char kPropertyBoard[] = "board";
@@ -69,7 +63,7 @@ base::Value* ChromeosInfoPrivateGetFunction::GetValue(
std::string hwid;
chromeos::system::StatisticsProvider* provider =
chromeos::system::StatisticsProvider::GetInstance();
- provider->GetMachineStatistic(kHardwareClass, &hwid);
+ provider->GetMachineStatistic(chromeos::system::kHardwareClass, &hwid);
return new base::StringValue(hwid);
} else if (property_name == kPropertyHomeProvider) {
NetworkLibrary* netlib = CrosLibrary::Get()->GetNetworkLibrary();
@@ -81,7 +75,7 @@ base::Value* ChromeosInfoPrivateGetFunction::GetValue(
std::string board;
chromeos::system::StatisticsProvider* provider =
chromeos::system::StatisticsProvider::GetInstance();
- provider->GetMachineStatistic(kPropertyReleaseBoard, &board);
+ provider->GetMachineStatistic(chromeos::system::kMachineInfoBoard, &board);
return new base::StringValue(board);
} else if (property_name == kPropertyOwner) {
return Value::CreateBooleanValue(

Powered by Google App Engine
This is Rietveld 408576698