[WIP][SVG 2/4] Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

Two different conditions are used for whether data URLs can be served locally:
- Resource::loadLocallyDataURL() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.

This CL makes these two the same, i.e. to use CanHandleDataURLRequestLocally().
This CL renames parseDataURL() to parseDataURLIfCanBeHandledLocally(), and
makes it to use CanHandleDataURLRequestLocally().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected due to MIME type checks in parseDataURL().

This CL might increase or decrease the number of net::DataURL::Parse() calls.

This CL is [2/4] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

BUG=382170

[hiroshige, 2016-02-16 22:07:35]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 22:08:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700233003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700233003/1

[commit-bot: I haz the power, 2016-02-16 23:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:49:41]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-02-17 18:53:11]

Description was changed from

==========
Allow any MIME types in BlinkPlatformImpl::parseDataURL()

BUG=
==========

to

==========
Allow any MIME types in BlinkPlatformImpl::parseDataURL()

This CL is [1/2] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

ResourceFetcher::preCacheData() adds Resource of a data: URL only if
parseDataURL() succeeds, but BlinkPlatformImpl::parseDataURL() succeeds only for
data: URLs with supported MIME types (which don't include font/ MIME types).

This CL allows any MIME types in BlinkPlatformImpl::parseDataURL(), and thus
makes data: URLs with font/ MIME types to be precached.

[1/2] Make data: URLs with font/ MIME types to be precached: This CL.
[2/2] Do not call Resource::load() for precached FontResource:
      https://codereview.chromium.org/1704693002/

BUG=382170
==========

[hiroshige, 2016-02-17 19:39:44]

Description was changed from

==========
Allow any MIME types in BlinkPlatformImpl::parseDataURL()

This CL is [1/2] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

ResourceFetcher::preCacheData() adds Resource of a data: URL only if
parseDataURL() succeeds, but BlinkPlatformImpl::parseDataURL() succeeds only for
data: URLs with supported MIME types (which don't include font/ MIME types).

This CL allows any MIME types in BlinkPlatformImpl::parseDataURL(), and thus
makes data: URLs with font/ MIME types to be precached.

[1/2] Make data: URLs with font/ MIME types to be precached: This CL.
[2/2] Do not call Resource::load() for precached FontResource:
      https://codereview.chromium.org/1704693002/

BUG=382170
==========

to

==========
Allow any MIME types in BlinkPlatformImpl::parseDataURL()

This CL is [1/2] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

ResourceFetcher::preCacheData() adds Resource of a data: URL only if
parseDataURL() succeeds, but BlinkPlatformImpl::parseDataURL() succeeds only for
data: URLs with supported MIME types (which don't include font/ MIME types).

This CL allows any MIME types in BlinkPlatformImpl::parseDataURL(), and thus
makes data: URLs with font/ MIME types to be precached.

[1/2] Make data: URLs with font/ MIME types to be precached: This CL.
[2/2] Do not call Resource::load() for precached FontResource:
      https://codereview.chromium.org/1704693002/

BUG=382170

memo: https://codereview.chromium.org/5542001
      https://codereview.chromium.org/16096016
R: darin, pdr
==========

[hiroshige, 2016-02-29 19:46:30]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 19:47:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700233003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700233003/60001

[commit-bot: I haz the power, 2016-02-29 20:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 20:28:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2016-02-29 21:17:13]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 21:17:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700233003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700233003/80001

[hiroshige, 2016-02-29 21:50:50]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 21:51:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700233003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700233003/100001

[commit-bot: I haz the power, 2016-02-29 23:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 23:25:55]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-03-01 18:19:25]

Description was changed from

==========
Allow any MIME types in BlinkPlatformImpl::parseDataURL()

This CL is [1/2] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

ResourceFetcher::preCacheData() adds Resource of a data: URL only if
parseDataURL() succeeds, but BlinkPlatformImpl::parseDataURL() succeeds only for
data: URLs with supported MIME types (which don't include font/ MIME types).

This CL allows any MIME types in BlinkPlatformImpl::parseDataURL(), and thus
makes data: URLs with font/ MIME types to be precached.

[1/2] Make data: URLs with font/ MIME types to be precached: This CL.
[2/2] Do not call Resource::load() for precached FontResource:
      https://codereview.chromium.org/1704693002/

BUG=382170

memo: https://codereview.chromium.org/5542001
      https://codereview.chromium.org/16096016
R: darin, pdr
==========

to

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
BlinkPlatformImpl::parseDataURL() succeeds, while WebURLLoaderImpl serves a
data: URL within the renderer process if
WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same, i.e.
ResourceFetcher and WebURLLoaderImpl should serve a data: URL if it can be
served within the renderer process.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher, and removed MIME check in
BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file:
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[3/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

[hiroshige, 2016-03-01 18:21:24]

Description was changed from

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
BlinkPlatformImpl::parseDataURL() succeeds, while WebURLLoaderImpl serves a
data: URL within the renderer process if
WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same, i.e.
ResourceFetcher and WebURLLoaderImpl should serve a data: URL if it can be
served within the renderer process.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher, and removed MIME check in
BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file:
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[3/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

to

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

- ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher,
and removes MIME check in BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file:
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[3/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

[hiroshige, 2016-03-01 18:24:19]

Description was changed from

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

- ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher,
and removes MIME check in BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file:
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[3/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

to

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

- ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher,
and removes MIME check in BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file:
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

[hiroshige, 2016-03-01 18:24:56]

Description was changed from

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

- ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher,
and removes MIME check in BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file:
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

to

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

- ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher,
and removes MIME check in BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file:
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/ (This CL)
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

[hiroshige, 2016-03-01 18:45:43]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, pdr@chromium.org

[hiroshige, 2016-03-01 18:45:43]

PTAL.

Added pdr@ as the author of https://codereview.chromium.org/16096016.

[pdr., 2016-03-01 18:52:06]

On 2016/03/01 at 18:45:43, hiroshige wrote:
> PTAL.
> 
> Added pdr@ as the author of https://codereview.chromium.org/16096016.

This looks good to me (as does the overall direction of these patches).

LGTM, but please wait for japhet to comment as well.

[Nate Chapin, 2016-03-01 19:11:37]

LGTM.

I don't especially like exposing canHandleDataURLRequestLocally() on Platform.
The alternative is to change parseDataURL() to have a WebData& data_out
parameter, and have it return a bool that indicates whether to handle locally.

Neither is ideal. I assume you prefer exposing canHandleDataURLRequestLocally()?

[hiroshige, 2016-03-01 20:18:20]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 20:18:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700233003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700233003/120001

[commit-bot: I haz the power, 2016-03-01 21:49:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 21:49:11]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-03-01 22:09:47]

On 2016/03/01 19:11:37, Nate Chapin wrote:
> LGTM.
> 
> I don't especially like exposing canHandleDataURLRequestLocally() on Platform.
> The alternative is to change parseDataURL() to have a WebData& data_out
> parameter, and have it return a bool that indicates whether to handle locally.
> 
> Neither is ideal. I assume you prefer exposing
canHandleDataURLRequestLocally()?

I changed the mind; it would be better to do data URL-related thing in a single
code block in content side, rather than invoking
canHandleDataURLRequestLocally() and parseDataURL() separately from Blink,
because there is a chance to merge two data URL parsing inside
canHandleDataURLRequestLocally() and parseDataURL() into one in the future.

In Patch Set 7, I added WebURLRequest and WebData arguments and renamed
parseDataURL() to parseDataURLIfCanBeHandledLocally() because it is no longer
simple parsing function.

[Nate Chapin, 2016-03-01 23:08:12]

lgtm

[hiroshige, 2016-03-02 22:44:12]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 22:44:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700233003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700233003/140001

[hiroshige, 2016-03-02 23:01:45]

Description was changed from

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

- ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher,
and removes MIME check in BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file:
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/ (This CL)
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

to

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

- ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher,
and removes MIME check in BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/4] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

BUG=382170
==========

[hiroshige, 2016-03-02 23:23:51]

Description was changed from

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

- ResourceFetcher::resourceForStaticData() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.
Currently these conditions are different, but can/should be the same.

This CL makes ResourceFetcher::resourceForStaticData() to use
CanHandleDataURLRequestLocally() to determine whether a data: URL can be
served by ResourceFetcher,
and removes MIME check in BlinkPlatformImpl::parseDataURL().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected in ResourceFetcher::resourceForStaticData()
due to MIME type checks in BlinkPlatformImpl::parseDataURL().

This CL might increase or decrease net::DataURL::Parse() calls.

This CL is [1/4] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

BUG=382170
==========

to

==========
Make data URL handling in ResourceFetcher and WebURLLoaderImpl consistent

Two different conditions are used for whether data URLs can be served locally:
- Resource::loadLocallyDataURL() creates Resource of a data: URL if
  BlinkPlatformImpl::parseDataURL() succeeds.
- WebURLLoaderImpl serves a data: URL within the renderer process if
  WebURLLoaderImpl::Context::CanHandleDataURLRequestLocally() returns true.

This CL makes these two the same, i.e. to use CanHandleDataURLRequestLocally().
This CL renames parseDataURL() to parseDataURLIfCanBeHandledLocally(), and
makes it to use CanHandleDataURLRequestLocally().

This change particularly allows data URLs with font/ MIME types loaded as
subresources to be served by ResourceFetcher synchronously.
They were previously rejected due to MIME type checks in parseDataURL().

This CL might increase or decrease the number of net::DataURL::Parse() calls.

This CL is [2/4] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

BUG=382170
==========

[commit-bot: I haz the power, 2016-03-03 00:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 00:17:57]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2016-03-30 01:22:47]

Patchset #9 (id:160001) has been deleted