Issue 16096016: Expose parseDataURL to Platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16096016: Expose parseDataURL to Platform (Closed)

Created:
7 years, 6 months ago by pdr.

Modified:
7 years, 6 months ago

Reviewers:
jamesr, abarth-chromium

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Expose parseDataURL to Platform This patch exposes data url parsing to WebKit. This is a Chromium-side change for https://codereview.chromium.org/16433002. BUG=224317 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204907

Patch Set 2 : Add names to params like a real Chrome engineer #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	webkit/glue/webkitplatformsupport_impl.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	webkit/glue/webkitplatformsupport_impl.cc	View		2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/16096016/diff/1/webkit/glue/webkitplatformsupport_impl.h File webkit/glue/webkitplatformsupport_impl.h (right): https://codereview.chromium.org/16096016/diff/1/webkit/glue/webkitplatformsupport_impl.h#newcode89 webkit/glue/webkitplatformsupport_impl.h:89: const WebKit::WebURL&, WebKit::WebString&, WebKit::WebString&); this is chromium style, ...

7 years, 6 months ago (2013-06-07 17:49:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/16096016/6001

7 years, 6 months ago (2013-06-07 18:19:14 UTC) #4

pdr.

7 years, 6 months ago (2013-06-07 20:21:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r204907 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16096016: Expose parseDataURL to Platform (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add names to params like a real Chrome engineer #

Messages