[Closed][SVG 4/4] Finish font subresource loading of SVG synchronously in SVGImage::dataChanged()

Finish font subresource loading of SVG synchronously in SVGImage::dataChanged()

This CL is [4/4] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

By [1/4], [2/4] and [3/4], data URLs for fonts can be served synchronously in
Resource::load().
But Resource::load() is not called synchronously in SVGImage::dataChanged(),
because FontLoader schedules loading asynchronously in addFontToBeginLoading().

This CL triggers font loading by calling FontLoader::loadPendingFonts().
Font loading is started and completed synchronously inside loadPendingFonts().

This CL also call FrameLoader::checkCompleted() to make sure
Document::loadEventFinished() becomes true after this call.

This CL adds layout tests to check SVG document's load event is finished before
load event of <img> for SVG files for various data font URLs.

BUG=382170

[hiroshige, 2016-02-16 22:31:24]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 22:34:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699323002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699323002/1

[commit-bot: I haz the power, 2016-02-16 23:32:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:32:17]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2016-02-17 02:20:14]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 02:20:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699323002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699323002/20001

[commit-bot: I haz the power, 2016-02-17 05:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 05:39:36]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-02-17 19:16:54]

Description was changed from

==========
Add a layout test for SVG that contains data URL as font

BUG=
==========

to

==========
Add a layout test for SVG that contains data URL as font

BUG=382170
==========

[hiroshige, 2016-02-17 19:35:10]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 19:37:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699323002/40001

[commit-bot: I haz the power, 2016-02-17 20:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 20:45:41]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2016-02-29 19:46:48]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 19:47:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699323002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699323002/60001

[commit-bot: I haz the power, 2016-02-29 20:23:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 20:23:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2016-02-29 22:00:53]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 22:02:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699323002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699323002/80001

[commit-bot: I haz the power, 2016-02-29 23:10:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 23:10:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2016-03-01 01:04:03]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 01:04:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699323002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699323002/100001

[commit-bot: I haz the power, 2016-03-01 03:12:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 03:12:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hiroshige, 2016-03-01 18:33:06]

Description was changed from

==========
Add a layout test for SVG that contains data URL as font

BUG=382170
==========

to

==========
Add layout tests for SVG that contains data URL as font

This CL is [4/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.
data-font-in-css-crash.html and data-font-in-css-invalid-font-crash.html tests
[1/5] and [2/5]. data-font-in-css-invalid-data-url-crash.html tests [3/5].
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/ (This CL)
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/
BUG=382170
==========

[hiroshige, 2016-03-01 18:33:39]

Description was changed from

==========
Add layout tests for SVG that contains data URL as font

This CL is [4/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.
data-font-in-css-crash.html and data-font-in-css-invalid-font-crash.html tests
[1/5] and [2/5]. data-font-in-css-invalid-data-url-crash.html tests [3/5].
[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/ (This CL)
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/
BUG=382170
==========

to

==========
Add layout tests for SVG that contains data URL as font

This CL is [4/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

data-font-in-css-crash.html and data-font-in-css-invalid-font-crash.html
tests [1/5] and [2/5].
data-font-in-css-invalid-data-url-crash.html tests [3/5].

[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/ (This CL)
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/
BUG=382170
==========

[hiroshige, 2016-03-01 18:34:18]

Description was changed from

==========
Add layout tests for SVG that contains data URL as font

This CL is [4/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

data-font-in-css-crash.html and data-font-in-css-invalid-font-crash.html
tests [1/5] and [2/5].
data-font-in-css-invalid-data-url-crash.html tests [3/5].

[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/ (This CL)
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/
BUG=382170
==========

to

==========
Add layout tests for SVG that contains data URL as font

This CL is [4/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

data-font-in-css-crash.html and data-font-in-css-invalid-font-crash.html
tests [1/5] and [2/5].
data-font-in-css-invalid-data-url-crash.html tests [3/5].

[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/ (This CL)
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

[hiroshige, 2016-03-01 18:48:41]

hiroshige@chromium.org changed reviewers:
+ kouhei@chromium.org

[hiroshige, 2016-03-01 18:48:42]

PTAL.

[hiroshige, 2016-03-01 20:32:36]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 20:32:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699323002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699323002/120001

[commit-bot: I haz the power, 2016-03-01 22:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 22:15:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2016-03-02 22:56:29]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 22:56:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699323002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699323002/140001

[hiroshige, 2016-03-02 23:10:52]

Description was changed from

==========
Add layout tests for SVG that contains data URL as font

This CL is [4/5] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

data-font-in-css-crash.html and data-font-in-css-invalid-font-crash.html
tests [1/5] and [2/5].
data-font-in-css-invalid-data-url-crash.html tests [3/5].

[1/5] Make fonts with data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1700233003/
[2/5] Do not reload FontResource created by resourceForStaticData().
      https://codereview.chromium.org/1704693002/
[3/5] Make invalid data: URLs to be served by resourceForStaticData().
      https://codereview.chromium.org/1707013002/
[4/5] Add layout tests.
      https://codereview.chromium.org/1699323002/ (This CL)
[5/5] Check SVG's subresource load completion in ImageLoader::notifyFinished().
      https://codereview.chromium.org/1515963005/

BUG=382170
==========

to

==========
Add layout tests for SVG that contains data URL as font

This CL is [4/4] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

By [1/4], [2/4] and [3/4], data URLs for fonts can be served synchronously in
Resource::load().
But Resource::load() is not called synchronously in SVGImage::dataChanged(),
because FontLoader schedules loading asynchronously in addFontToBeginLoading().

This CL triggers font loading by calling FontLoader::loadPendingFonts().
Font loading is started and completed synchronously inside loadPendingFonts().

This CL also call FrameLoader::checkCompleted() to make sure
Document::loadEventFinished() becomes true after this call.

BUG=382170
==========

[hiroshige, 2016-03-02 23:14:21]

Description was changed from

==========
Add layout tests for SVG that contains data URL as font

This CL is [4/4] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

By [1/4], [2/4] and [3/4], data URLs for fonts can be served synchronously in
Resource::load().
But Resource::load() is not called synchronously in SVGImage::dataChanged(),
because FontLoader schedules loading asynchronously in addFontToBeginLoading().

This CL triggers font loading by calling FontLoader::loadPendingFonts().
Font loading is started and completed synchronously inside loadPendingFonts().

This CL also call FrameLoader::checkCompleted() to make sure
Document::loadEventFinished() becomes true after this call.

BUG=382170
==========

to

==========
Finish font subresource loading of SVG synchronously in SVGImage::dataChanged()

This CL is [4/4] to load FontResource of data: URLs synchronously so that
all subresource loading of SVG image completes before loading of the SVG file.

By [1/4], [2/4] and [3/4], data URLs for fonts can be served synchronously in
Resource::load().
But Resource::load() is not called synchronously in SVGImage::dataChanged(),
because FontLoader schedules loading asynchronously in addFontToBeginLoading().

This CL triggers font loading by calling FontLoader::loadPendingFonts().
Font loading is started and completed synchronously inside loadPendingFonts().

This CL also call FrameLoader::checkCompleted() to make sure
Document::loadEventFinished() becomes true after this call.

This CL adds layout tests to check SVG document's load event is finished before
load event of <img> for SVG files for various data font URLs.

BUG=382170
==========

[commit-bot: I haz the power, 2016-03-03 00:07:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 00:07:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2016-03-03 00:10:06]

Due to Font delayed loading issues, I'm currently modifying CLs and this CL is
not ready for review now.

[hiroshige, 2017-05-18 22:25:11]

Closing, as https://codereview.chromium.org/2613853002/ (using a different
approach) is landed. Tests are landed there.