Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1699973002: Remove HostDesktopType from BrowserWithTestWindowTest (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-22
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from BrowserWithTestWindowTest R=sky@chromium.org BUG=558054 Committed: https://crrev.com/505cf01d5f6d69360bb730ebd191f3f63230a9ef Cr-Commit-Position: refs/heads/master@{#375806}

Patch Set 1 #

Total comments: 2

Patch Set 2 : delegated ctor #

Patch Set 3 : cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -98 lines) Patch
M chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 2 2 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_unittest.cc View 3 chunks +4 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 1 2 2 chunks +4 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/frame/test_with_browser_view.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/test_with_browser_view.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash_unittest.cc View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 4 chunks +3 lines, -10 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 3 chunks +6 lines, -15 lines 0 comments Download

Depends on Patchset:

Issue 1697223002 Patch 20001

Dependent Patchsets:

Issue 1698123003 Patch 20001

Messages

Total messages: 9 (3 generated)
scottmg
4 years, 10 months ago (2016-02-15 21:25:49 UTC) #1
sky
LGTM https://codereview.chromium.org/1699973002/diff/1/chrome/test/base/browser_with_test_window_test.cc File chrome/test/base/browser_with_test_window_test.cc (right): https://codereview.chromium.org/1699973002/diff/1/chrome/test/base/browser_with_test_window_test.cc#newcode41 chrome/test/base/browser_with_test_window_test.cc:41: : browser_type_(Browser::TYPE_TABBED), hosted_app_(false) {} nit: use delegating constructors.
4 years, 10 months ago (2016-02-16 02:59:04 UTC) #2
scottmg
https://codereview.chromium.org/1699973002/diff/1/chrome/test/base/browser_with_test_window_test.cc File chrome/test/base/browser_with_test_window_test.cc (right): https://codereview.chromium.org/1699973002/diff/1/chrome/test/base/browser_with_test_window_test.cc#newcode41 chrome/test/base/browser_with_test_window_test.cc:41: : browser_type_(Browser::TYPE_TABBED), hosted_app_(false) {} On 2016/02/16 02:59:04, sky wrote: ...
4 years, 10 months ago (2016-02-17 05:33:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699973002/40001
4 years, 10 months ago (2016-02-17 05:34:54 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-17 06:07:39 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 06:09:02 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/505cf01d5f6d69360bb730ebd191f3f63230a9ef
Cr-Commit-Position: refs/heads/master@{#375806}

Powered by Google App Engine
This is Rietveld 408576698