Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1697223002: Remove HostDesktopType from c/b/ui/bookmarks (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-21
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from c/b/ui/bookmarks R=sky@chromium.org BUG=558054 Committed: https://crrev.com/cf186a3887a562701a0f52b216a4b05ac136d0f0 Cr-Commit-Position: refs/heads/master@{#375796}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #else and mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 1 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1699963002 Patch 70001

Dependent Patchsets:

Issue 1699973002 Patch 20001
Issue 1699973002 Patch 40001

Messages

Total messages: 9 (3 generated)
scottmg
4 years, 10 months ago (2016-02-15 20:51:54 UTC) #1
sky
LGTM https://codereview.chromium.org/1697223002/diff/1/chrome/browser/ui/bookmarks/bookmark_utils.cc File chrome/browser/ui/bookmarks/bookmark_utils.cc (right): https://codereview.chromium.org/1697223002/diff/1/chrome/browser/ui/bookmarks/bookmark_utils.cc#newcode152 chrome/browser/ui/bookmarks/bookmark_utils.cc:152: #endif Similar comment about #else.
4 years, 10 months ago (2016-02-16 02:58:04 UTC) #2
scottmg
https://codereview.chromium.org/1697223002/diff/1/chrome/browser/ui/bookmarks/bookmark_utils.cc File chrome/browser/ui/bookmarks/bookmark_utils.cc (right): https://codereview.chromium.org/1697223002/diff/1/chrome/browser/ui/bookmarks/bookmark_utils.cc#newcode152 chrome/browser/ui/bookmarks/bookmark_utils.cc:152: #endif On 2016/02/16 02:58:04, sky wrote: > Similar comment ...
4 years, 10 months ago (2016-02-17 03:12:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697223002/20001
4 years, 10 months ago (2016-02-17 04:33:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 05:27:02 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 05:28:19 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cf186a3887a562701a0f52b216a4b05ac136d0f0
Cr-Commit-Position: refs/heads/master@{#375796}

Powered by Google App Engine
This is Rietveld 408576698