Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1698123003: Remove HostDesktopType from interactive_test_utils_win (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-23
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from interactive_test_utils_win R=sky@chromium.org BUG=558054 Committed: https://crrev.com/7542e22af8b673649fb8349a726438d8b79d1d59 Cr-Commit-Position: refs/heads/master@{#375911}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #else #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chrome/test/base/interactive_test_utils_win.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 1699973002 Patch 40001

Dependent Patchsets:

Issue 1701793002 Patch 20001

Messages

Total messages: 9 (3 generated)
scottmg
4 years, 10 months ago (2016-02-15 21:37:36 UTC) #1
sky
LGTM https://codereview.chromium.org/1698123003/diff/1/chrome/test/base/interactive_test_utils_win.cc File chrome/test/base/interactive_test_utils_win.cc (right): https://codereview.chromium.org/1698123003/diff/1/chrome/test/base/interactive_test_utils_win.cc#newcode26 chrome/test/base/interactive_test_utils_win.cc:26: #endif // USE_ASH #else here and below.
4 years, 10 months ago (2016-02-16 02:59:50 UTC) #2
scottmg
https://codereview.chromium.org/1698123003/diff/1/chrome/test/base/interactive_test_utils_win.cc File chrome/test/base/interactive_test_utils_win.cc (right): https://codereview.chromium.org/1698123003/diff/1/chrome/test/base/interactive_test_utils_win.cc#newcode26 chrome/test/base/interactive_test_utils_win.cc:26: #endif // USE_ASH On 2016/02/16 02:59:50, sky wrote: > ...
4 years, 10 months ago (2016-02-17 05:36:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698123003/20001
4 years, 10 months ago (2016-02-17 17:18:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 17:25:11 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 17:27:38 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7542e22af8b673649fb8349a726438d8b79d1d59
Cr-Commit-Position: refs/heads/master@{#375911}

Powered by Google App Engine
This is Rietveld 408576698