Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/test/base/browser_with_test_window_test.h

Issue 1699973002: Remove HostDesktopType from BrowserWithTestWindowTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-22
Patch Set: cros Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/browser_with_test_window_test.h
diff --git a/chrome/test/base/browser_with_test_window_test.h b/chrome/test/base/browser_with_test_window_test.h
index 760e4125663cdc636e03e31e8b511e99ba8844b5..d0d9af54d872c23657ad06391ac8fe4ce7b032f9 100644
--- a/chrome/test/base/browser_with_test_window_test.h
+++ b/chrome/test/base/browser_with_test_window_test.h
@@ -10,7 +10,6 @@
#include "base/message_loop/message_loop.h"
#include "build/build_config.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/host_desktop.h"
#include "chrome/test/base/test_browser_window.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -76,9 +75,7 @@ class BrowserWithTestWindowTest : public testing::Test {
// Creates a BrowserWithTestWindowTest for which the initial window will be
// the specified type.
- BrowserWithTestWindowTest(Browser::Type browser_type,
- chrome::HostDesktopType host_desktop_type,
- bool hosted_app);
+ BrowserWithTestWindowTest(Browser::Type browser_type, bool hosted_app);
~BrowserWithTestWindowTest() override;
@@ -144,12 +141,11 @@ class BrowserWithTestWindowTest : public testing::Test {
// value. Can return NULL to use the default window created by Browser.
virtual BrowserWindow* CreateBrowserWindow();
- // Creates the browser given |profile|, |browser_type|, |hosted_app|,
- // |host_desktop_type| and |browser_window|. The caller owns the return value.
+ // Creates the browser given |profile|, |browser_type|, |hosted_app|, and
+ // |browser_window|. The caller owns the return value.
virtual Browser* CreateBrowser(Profile* profile,
Browser::Type browser_type,
bool hosted_app,
- chrome::HostDesktopType host_desktop_type,
BrowserWindow* browser_window);
private:
@@ -187,9 +183,6 @@ class BrowserWithTestWindowTest : public testing::Test {
// The type of browser to create (tabbed or popup).
Browser::Type browser_type_;
- // The desktop to create the initial window on.
- chrome::HostDesktopType host_desktop_type_;
-
// Whether the browser is part of a hosted app.
bool hosted_app_;

Powered by Google App Engine
This is Rietveld 408576698