Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1699963002: Remove HostDesktopType from CreateImmersiveModeController (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-20
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from CreateImmersiveModeController R=sky@chromium.org BUG=558054 Committed: https://crrev.com/8b57decd949396b83075315323a3c2778a176ce8 Cr-Commit-Position: refs/heads/master@{#375790}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : #else #

Patch Set 4 : non-win #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_factory_mac.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc View 1 2 2 chunks +4 lines, -7 lines 0 comments Download

Depends on Patchset:

Issue 1697183003 Patch 40001

Dependent Patchsets:

Issue 1697223002 Patch 20001

Messages

Total messages: 9 (3 generated)
scottmg
4 years, 10 months ago (2016-02-15 20:16:00 UTC) #1
sky
LGTM https://codereview.chromium.org/1699963002/diff/20001/chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc File chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc (right): https://codereview.chromium.org/1699963002/diff/20001/chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc#newcode16 chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc:16: #endif #else? (I believe we enabled warnings for ...
4 years, 10 months ago (2016-02-16 02:57:10 UTC) #2
scottmg
https://codereview.chromium.org/1699963002/diff/20001/chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc File chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc (right): https://codereview.chromium.org/1699963002/diff/20001/chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc#newcode16 chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc:16: #endif On 2016/02/16 02:57:10, sky wrote: > #else? (I ...
4 years, 10 months ago (2016-02-17 00:12:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699963002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699963002/70001
4 years, 10 months ago (2016-02-17 03:04:02 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:70001)
4 years, 10 months ago (2016-02-17 04:19:48 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 04:21:52 UTC) #9
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/8b57decd949396b83075315323a3c2778a176ce8
Cr-Commit-Position: refs/heads/master@{#375790}

Powered by Google App Engine
This is Rietveld 408576698