chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc - Issue 1699963002: Remove HostDesktopType from CreateImmersiveModeController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc

Issue 1699963002: Remove HostDesktopType from CreateImmersiveModeController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-20

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/host_desktop.h"

6 #include "chrome/browser/ui/views/frame/immersive_mode_controller_stub.h"	5 #include "chrome/browser/ui/views/frame/immersive_mode_controller_stub.h"

7	6

8 #if defined(USE_ASH)	7 #if defined(USE_ASH)

9 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"	8 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"

10 #endif	9 #endif

11	10

12 namespace chrome {	11 namespace chrome {

13	12

14 ImmersiveModeController* CreateImmersiveModeController(	13 ImmersiveModeController* CreateImmersiveModeController() {

15 chrome::HostDesktopType host_desktop_type) {

16 #if defined(USE_ASH)	14 #if defined(USE_ASH)

17 if (host_desktop_type == chrome::HOST_DESKTOP_TYPE_ASH)	15 return new ImmersiveModeControllerAsh();

18 return new ImmersiveModeControllerAsh();

19 #endif	16 #endif
	sky 2016/02/16 02:57:10 #else? (I believe we enabled warnings for control #else? (I believe we enabled warnings for control flow like you would have here if USE_ASH were turned on with windows). scottmg 2016/02/17 00:12:49 Done. Show quoted text On 2016/02/16 02:57:10, sky wrote: > #else? (I believe we enabled warnings for control flow like you would have here > if USE_ASH were turned on with windows). Done.
20	17

21 return new ImmersiveModeControllerStub();	18 return new ImmersiveModeControllerStub();

22 }	19 }

23	20

24 } // namespace chrome	21 } // namespace chrome

OLD	NEW

« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_factory_mac.cc ('k') | no next file » | no next file with comments »