Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1697183003: Remove HostDesktopType from sessions and tab restore (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
Reviewers:
stuartmorgan, sky, sdefresne
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, kalyank, sadrul, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-19
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HostDesktopType from sessions and tab restore R=sky@chromium.org, stuartmorgan@chromium.org BUG=558054 Committed: https://crrev.com/d161e6c467bcb73373eab25b92ef4c772bced04c Cr-Commit-Position: refs/heads/master@{#375753}

Patch Set 1 #

Patch Set 2 : mac and android #

Patch Set 3 : mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -127 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 4 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/sessions/chrome_tab_restore_service_client.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sessions/chrome_tab_restore_service_client.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_live_tab_context.h View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_live_tab_context.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_tab_restorer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabrestore_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/in_memory_tab_restore_service.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/sessions/core/in_memory_tab_restore_service.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M components/sessions/core/persistent_tab_restore_service.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/sessions/core/persistent_tab_restore_service.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M components/sessions/core/tab_restore_service.h View 2 chunks +4 lines, -11 lines 0 comments Download
M components/sessions/core/tab_restore_service_client.h View 1 chunk +7 lines, -15 lines 0 comments Download
M components/sessions/core/tab_restore_service_helper.h View 2 chunks +6 lines, -11 lines 0 comments Download
M components/sessions/core/tab_restore_service_helper.cc View 8 chunks +7 lines, -15 lines 0 comments Download
M ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.h View 1 chunk +1 line, -3 lines 0 comments Download
M ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.cc View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Issue 1689423003 Patch 1

Dependent Patchsets:

Issue 1699963002 Patch 50001
Issue 1699963002 Patch 70001

Messages

Total messages: 17 (8 generated)
scottmg
sky: chrome/ and components/sessions/ stuartmorgan: ios/
4 years, 10 months ago (2016-02-15 19:47:46 UTC) #1
sky
LGTM
4 years, 10 months ago (2016-02-16 02:55:36 UTC) #2
sdefresne
ios lgtm
4 years, 10 months ago (2016-02-16 08:09:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697183003/1
4 years, 10 months ago (2016-02-16 23:59:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/22559) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-17 00:23:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697183003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697183003/20001
4 years, 10 months ago (2016-02-17 00:29:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697183003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697183003/40001
4 years, 10 months ago (2016-02-17 01:10:57 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-17 02:08:08 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 02:09:57 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d161e6c467bcb73373eab25b92ef4c772bced04c
Cr-Commit-Position: refs/heads/master@{#375753}

Powered by Google App Engine
This is Rietveld 408576698