Blink Compositor: Erase virtuals on Transform and Filter operations.

Blink Compositor: Erase virtuals on Transform and Filter operations.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3479a2cd4a2926b56ea8091e6182f1a32e9bbeae
Cr-Commit-Position: refs/heads/master@{#376085}

[loyso (OOO), 2016-02-16 05:24:44]

Description was changed from

==========
Blink Compositor: Erase virtuals on Transform and Filter operations.

BUG=577016
==========

to

==========
Blink Compositor: Erase virtuals on Transform and Filter operations.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-02-16 05:28:13]

Description was changed from

==========
Blink Compositor: Erase virtuals on Transform and Filter operations.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Blink Compositor: Erase virtuals on Transform and Filter operations.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-02-16 05:28:13]

loyso@chromium.org changed reviewers:
+ alancutter@chromium.org, esprehn@chromium.org, jbroman@chromium.org,
vollick@chromium.org

[loyso (OOO), 2016-02-16 05:28:24]

** Presubmit ERRORS **
Do not use Chromium namespace cc inside Blink core:
third_party/WebKit/Source/core/animation/AnimationTranslationUtilTest.cpp:54
third_party/WebKit/Source/core/animation/AnimationTranslationUtilTest.cpp:60
third_party/WebKit/Source/core/animation/AnimationTranslationUtilTest.cpp:67
third_party/WebKit/Source/core/animation/AnimationTranslationUtilTest.cpp:88
third_party/WebKit/Source/core/animation/AnimationTranslationUtilTest.cpp:92
third_party/WebKit/Source/core/animation/AnimationTranslationUtilTest.cpp:96
third_party/WebKit/Source/core/animation/AnimationTranslationUtilTest.cpp:100

Can we allow to use cc namespace in Test files?
Otherwise, I have to setup a special helpers in platform/graphics for this test.

[loyso (OOO), 2016-02-16 05:31:44]

loyso@chromium.org changed reviewers:
+ dstockwell@chromium.org

[loyso (OOO), 2016-02-17 23:28:55]

PTAL, jbroman@, esprehn@! Can we allow to use cc namespace in Test files?

[jbroman, 2016-02-17 23:31:01]

On 2016/02/17 at 23:28:55, loyso wrote:
> PTAL, jbroman@, esprehn@! Can we allow to use cc namespace in Test files?

I'll leave this one to esprehn@; I'm not sure what the policy is here.

[loyso (OOO), 2016-02-17 23:46:41]

On 2016/02/17 23:31:01, jbroman wrote:
> On 2016/02/17 at 23:28:55, loyso wrote:
> > PTAL, jbroman@, esprehn@! Can we allow to use cc namespace in Test files?
> 
> I'll leave this one to esprehn@; I'm not sure what the policy is here.

In theory, we could expose cc internals for testing in some
Source/platform/animation/CompositorAnimationTest.h:
namespace blink {
using CCTransformOperationForTesting = cc::TransformOperation;
using CCFilterOperationForTesting = cc::FilterOperation;
}

[esprehn, 2016-02-18 00:02:02]

Why isn't the test in platform?

[jbroman, 2016-02-18 00:04:19]

On 2016/02/18 at 00:02:02, esprehn wrote:
> Why isn't the test in platform?

Wow, well-spotted. I totally missed that AnimationTranslationUtil doesn't use
anything from core/.

[loyso (OOO), 2016-02-18 00:10:54]

On 2016/02/18 00:04:19, jbroman wrote:
> On 2016/02/18 at 00:02:02, esprehn wrote:
> > Why isn't the test in platform?
> 
> Wow, well-spotted. I totally missed that AnimationTranslationUtil doesn't use
> anything from core/.

toCompositorOperations uses blink::TransformOperations. I thought it was in core
but it is platform/transforms/TransformOperations.h indeed.
Thanks! :)

[loyso (OOO), 2016-02-18 00:56:50]

On 2016/02/18 00:02:02, esprehn wrote:
> Why isn't the test in platform?
Done. PTAL! ready to be landed.

[ajuma, 2016-02-18 01:04:36]

ajuma@chromium.org changed reviewers:
+ ajuma@chromium.org

[ajuma, 2016-02-18 01:04:37]

cc/ lgtm

[esprehn, 2016-02-18 01:09:05]

lgtm

[esprehn, 2016-02-18 02:12:00]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2016-02-18 02:12:19]

The CQ bit was unchecked by esprehn@chromium.org

[esprehn, 2016-02-18 02:12:59]

Err I was going to commit this, but maybe someone from animations (alancutter or
dstockwell) should stamp it first? :)

[dstockwell, 2016-02-18 02:58:01]

lgtm

[esprehn, 2016-02-18 03:06:27]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-02-18 03:06:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698213002/20001

[commit-bot: I haz the power, 2016-02-18 04:01:02]

Description was changed from

==========
Blink Compositor: Erase virtuals on Transform and Filter operations.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Blink Compositor: Erase virtuals on Transform and Filter operations.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-02-18 04:01:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-18 04:02:11]

Description was changed from

==========
Blink Compositor: Erase virtuals on Transform and Filter operations.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Blink Compositor: Erase virtuals on Transform and Filter operations.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3479a2cd4a2926b56ea8091e6182f1a32e9bbeae
Cr-Commit-Position: refs/heads/master@{#376085}
==========

[commit-bot: I haz the power, 2016-02-18 04:02:12]

Patchset 2 (id:??) landed as
https://crrev.com/3479a2cd4a2926b56ea8091e6182f1a32e9bbeae
Cr-Commit-Position: refs/heads/master@{#376085}