Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1697523003: make SkComposeShader.h private (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
Reviewers:
scroggo, djsollen, reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -105 lines) Patch
M gm/composeshader.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M gyp/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D include/core/SkComposeShader.h View 1 chunk +0 lines, -90 lines 0 comments Download
M samplecode/PerlinPatch.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M samplecode/SampleAll.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M samplecode/SampleArc.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleShaders.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
A + src/core/SkComposeShader.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/core/SkComposeShader.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697523003/1
4 years, 10 months ago (2016-02-13 03:15:08 UTC) #3
reed1
4 years, 10 months ago (2016-02-13 03:15:22 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697523003/20001
4 years, 10 months ago (2016-02-13 03:26:14 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-13 03:49:47 UTC) #10
djsollen
lgtm
4 years, 10 months ago (2016-02-13 05:09:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697523003/20001
4 years, 10 months ago (2016-02-15 16:04:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/8681e60b2ccd4cea37128a129f1adf6a6d59bb7d
4 years, 10 months ago (2016-02-15 16:27:17 UTC) #15
scroggo
On 2016/02/15 16:27:17, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
4 years, 10 months ago (2016-02-16 14:59:51 UTC) #16
scroggo
4 years, 10 months ago (2016-02-16 15:36:00 UTC) #17
Message was sent while issue was closed. 
On 2016/02/16 14:59:51, scroggo wrote:
> On 2016/02/15 16:27:17, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
https://skia.googlesource.com/skia/+/8681e60b2ccd4cea37128a129f1adf6a6d59bb7d
> 
> LGTM
> 
> FYI: I was a little surprised that this hadn't caused any problems, since
> ag/865668 had not landed yet (that CL switches them to call the new method on
> SkShader; I just landed it now). But frameworks/base/core/jni/Android.mk still
> includes external/skia/src/core in LOCAL_C_INCLUDES, so it was still able to
> access that header. I haven't yet checked to see if it's still necessary to
> include src/core...

A couple of files think they need SkScalerContext.h, but they really do not. One
actually transitively wants SkGlyph.h, so I've uploaded a CL which corrects
those (ag/866539). There may be others they still need...

Powered by Google App Engine
This is Rietveld 408576698