Editing: Make the |EditingState*| argument of CompositeEditCommand::removeNode mandatory.

Editing: Make the |EditingState*| argument of CompositeEditCommand::removeNode mandatory.

This CL doesn't introduce new ASSERT_NO_EDITING_ABORTs except cases where node
removal won't dispatch synchronous events.

This CL has no tests.  We're not sure if this CL makes user-visible behavior
changes.  The purpose of this CL is to reduce ClusterFuzz crashes in the future.

BUG=586846
Committed: https://crrev.com/4ee37b1afc847d9504c046f20602709a98e921dc
Cr-Commit-Position: refs/heads/master@{#375417}

[tkent, 2016-02-15 05:25:15]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-02-15 05:25:16]

yosin@, would you review this please?

[yosin_UTC9, 2016-02-15 05:35:45]

lgtm

Thanks for changes!

Mixed-editaiblity exists since beginning and it is fundamental implementation
issue of editing command. Current behavior is what we don't expect and breaks
contract, e.g. modifying nodes out of editing boundary.

[yosin_UTC9, 2016-02-15 05:35:48]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-02-15 05:35:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695153002/1

[tkent, 2016-02-15 06:03:47]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-02-15 06:04:26]

Some tests are crashing with assertion failures.  Investigating.

[tkent, 2016-02-15 06:22:37]

https://codereview.chromium.org/1695153002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/1695153002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:495:
return
Wow, the missing ';' caused surprising results!!

[tkent, 2016-02-15 06:23:57]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-02-15 06:23:58]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1695153002/#ps20001
(title: ";")

[commit-bot: I haz the power, 2016-02-15 06:24:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695153002/20001

[commit-bot: I haz the power, 2016-02-15 07:36:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:48:58]

Description was changed from

==========
Editing: Make the |EditingState*| argument of CompositeEditCommand::removeNode
mandatory.

This CL doesn't introduce new ASSERT_NO_EDITING_ABORTs except cases where node
removal won't dispatch synchronous events.

This CL has no tests.  We're not sure if this CL makes user-visible behavior
changes.  The purpose of this CL is to reduce ClusterFuzz crashes in the future.

BUG=586846
==========

to

==========
Editing: Make the |EditingState*| argument of CompositeEditCommand::removeNode
mandatory.

This CL doesn't introduce new ASSERT_NO_EDITING_ABORTs except cases where node
removal won't dispatch synchronous events.

This CL has no tests.  We're not sure if this CL makes user-visible behavior
changes.  The purpose of this CL is to reduce ClusterFuzz crashes in the future.

BUG=586846

Committed: https://crrev.com/4ee37b1afc847d9504c046f20602709a98e921dc
Cr-Commit-Position: refs/heads/master@{#375417}
==========

[commit-bot: I haz the power, 2016-02-16 22:48:58]

Patchset 2 (id:??) landed as
https://crrev.com/4ee37b1afc847d9504c046f20602709a98e921dc
Cr-Commit-Position: refs/heads/master@{#375417}