Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h

Issue 1695153002: Editing: Make the |EditingState*| argument of CompositeEditCommand::removeNode mandatory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ; Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 void doApply(EditingState*) override; 53 void doApply(EditingState*) override;
54 EditAction editingAction() const override; 54 EditAction editingAction() const override;
55 55
56 bool preservesTypingStyle() const override; 56 bool preservesTypingStyle() const override;
57 57
58 void initializeStartEnd(Position&, Position&); 58 void initializeStartEnd(Position&, Position&);
59 void setStartingSelectionOnSmartDelete(const Position&, const Position&); 59 void setStartingSelectionOnSmartDelete(const Position&, const Position&);
60 void initializePositionData(); 60 void initializePositionData();
61 void saveTypingStyleState(); 61 void saveTypingStyleState();
62 bool handleSpecialCaseBRDelete(); 62 bool handleSpecialCaseBRDelete(EditingState*);
63 void handleGeneralDelete(EditingState*); 63 void handleGeneralDelete(EditingState*);
64 void fixupWhitespace(); 64 void fixupWhitespace();
65 void mergeParagraphs(); 65 void mergeParagraphs(EditingState*);
66 void removePreviouslySelectedEmptyTableRows(); 66 void removePreviouslySelectedEmptyTableRows(EditingState*);
67 void calculateTypingStyleAfterDelete(); 67 void calculateTypingStyleAfterDelete();
68 void clearTransientState(); 68 void clearTransientState();
69 void makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss(); 69 void makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss(Editi ngState*);
70 void removeNode(PassRefPtrWillBeRawPtr<Node>, EditingState* = ASSERT_NO_EDIT ING_ABORT, ShouldAssumeContentIsAlwaysEditable = DoNotAssumeContentIsAlwaysEdita ble) override; 70 void removeNode(PassRefPtrWillBeRawPtr<Node>, EditingState*, ShouldAssumeCon tentIsAlwaysEditable = DoNotAssumeContentIsAlwaysEditable) override;
71 void deleteTextFromNode(PassRefPtrWillBeRawPtr<Text>, unsigned, unsigned) ov erride; 71 void deleteTextFromNode(PassRefPtrWillBeRawPtr<Text>, unsigned, unsigned) ov erride;
72 void removeRedundantBlocks(EditingState*); 72 void removeRedundantBlocks(EditingState*);
73 73
74 bool m_hasSelectionToDelete; 74 bool m_hasSelectionToDelete;
75 bool m_smartDelete; 75 bool m_smartDelete;
76 bool m_mergeBlocksAfterDelete; 76 bool m_mergeBlocksAfterDelete;
77 bool m_needPlaceholder; 77 bool m_needPlaceholder;
78 bool m_expandForSpecialElements; 78 bool m_expandForSpecialElements;
79 bool m_pruneStartBlockIfNecessary; 79 bool m_pruneStartBlockIfNecessary;
80 bool m_startsAtEmptyLine; 80 bool m_startsAtEmptyLine;
(...skipping 15 matching lines...) Expand all
96 RefPtrWillBeMember<Element> m_startRoot; 96 RefPtrWillBeMember<Element> m_startRoot;
97 RefPtrWillBeMember<Element> m_endRoot; 97 RefPtrWillBeMember<Element> m_endRoot;
98 RefPtrWillBeMember<HTMLTableRowElement> m_startTableRow; 98 RefPtrWillBeMember<HTMLTableRowElement> m_startTableRow;
99 RefPtrWillBeMember<HTMLTableRowElement> m_endTableRow; 99 RefPtrWillBeMember<HTMLTableRowElement> m_endTableRow;
100 RefPtrWillBeMember<Node> m_temporaryPlaceholder; 100 RefPtrWillBeMember<Node> m_temporaryPlaceholder;
101 }; 101 };
102 102
103 } // namespace blink 103 } // namespace blink
104 104
105 #endif // DeleteSelectionCommand_h 105 #endif // DeleteSelectionCommand_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698