third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h - Issue 1695153002: Editing: Make the |EditingState*| argument of CompositeEditCommand::removeNode mandatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h

Issue 1695153002: Editing: Make the |EditingState*| argument of CompositeEditCommand::removeNode mandatory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ; Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h

index 6e8ea714194d90ac9c68d7f5778e5a05b270cf00..af4e2c70b1470a34b49ffb0a7db2b2a717f0276b 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h

@@ -59,15 +59,15 @@ private:

void setStartingSelectionOnSmartDelete(const Position&, const Position&);

void initializePositionData();

void saveTypingStyleState();

- bool handleSpecialCaseBRDelete();

+ bool handleSpecialCaseBRDelete(EditingState*);

void handleGeneralDelete(EditingState*);

void fixupWhitespace();

- void mergeParagraphs();

- void removePreviouslySelectedEmptyTableRows();

+ void mergeParagraphs(EditingState*);

+ void removePreviouslySelectedEmptyTableRows(EditingState*);

void calculateTypingStyleAfterDelete();

void clearTransientState();

- void makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss();

- void removeNode(PassRefPtrWillBeRawPtr<Node>, EditingState* = ASSERT_NO_EDITING_ABORT, ShouldAssumeContentIsAlwaysEditable = DoNotAssumeContentIsAlwaysEditable) override;

+ void makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss(EditingState*);

+ void removeNode(PassRefPtrWillBeRawPtr<Node>, EditingState*, ShouldAssumeContentIsAlwaysEditable = DoNotAssumeContentIsAlwaysEditable) override;

void deleteTextFromNode(PassRefPtrWillBeRawPtr<Text>, unsigned, unsigned) override;

void removeRedundantBlocks(EditingState*);