third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h - Issue 1695153002: Editing: Make the |EditingState*| argument of CompositeEditCommand::removeNode mandatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

Issue 1695153002: Editing: Make the |EditingState*| argument of CompositeEditCommand::removeNode mandatory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ; Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

index 4a36cb3e9d297177873277edd346f503fca0c632..09d151d23039d57957a0074c0e7e9a2c53d7cff2 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

@@ -94,8 +94,8 @@ private:

void removeUnrenderedTextNodesAtEnds(InsertedNodes&);

void removeRedundantStylesAndKeepStyleSpanInline(InsertedNodes&);

- void makeInsertedContentRoundTrippableWithHTMLTreeBuilder(const InsertedNodes&);

- void moveElementOutOfAncestor(PassRefPtrWillBeRawPtr<Element>, PassRefPtrWillBeRawPtr<Element> ancestor);

+ void makeInsertedContentRoundTrippableWithHTMLTreeBuilder(const InsertedNodes&, EditingState*);

+ void moveElementOutOfAncestor(PassRefPtrWillBeRawPtr<Element>, PassRefPtrWillBeRawPtr<Element> ancestor, EditingState*);

void handleStyleSpans(InsertedNodes&);

VisiblePosition positionAtStartOfInsertedContent() const;

@@ -103,10 +103,10 @@ private:

bool shouldPerformSmartReplace() const;

void addSpacesForSmartReplace();

- void completeHTMLReplacement(const Position& lastPositionToSelect);

- void mergeTextNodesAroundPosition(Position&, Position& positionOnlyToBeUpdated);

+ void completeHTMLReplacement(const Position& lastPositionToSelect, EditingState*);

+ void mergeTextNodesAroundPosition(Position&, Position& positionOnlyToBeUpdated, EditingState*);

- bool performTrivialReplace(const ReplacementFragment&);

+ bool performTrivialReplace(const ReplacementFragment&, EditingState*);

Position m_startOfInsertedContent;

Position m_endOfInsertedContent;