Issue 169273002: Remove support for [LegacyImplementedInBaseClass] IDL extended attribute

Issue 169273002: Remove support for [LegacyImplementedInBaseClass] IDL extended attribute (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
haraken, Nils Barth (inactive)

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove support for [LegacyImplementedInBaseClass] IDL extended attribute Remove support for [LegacyImplementedInBaseClass] IDL extended attribute now that the refactoring is complete. R=haraken, nbarth@chromium.org BUG=344224 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167280

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -21 lines)			Patch
M	Source/bindings/IDLExtendedAttributes.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/scripts/compute_dependencies.py	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/bindings/scripts/generate_bindings.pl	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/scripts/unstable/interface_dependency_resolver.py	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/bindings/tests/idls/TestImplements3.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestInterfacePython.cpp	View	7 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/169273002/30001

6 years, 10 months ago (2014-02-17 15:44:47 UTC) #4

Nils Barth (inactive)

6 years, 10 months ago (2014-02-19 01:49:10 UTC) #6

Message was sent while issue was closed.

Thanks for doing this Chris!

There are a few followups needed, which I've done at:
IDL compiler: omit header for WindowMediaSource.idl in Python
https://codereview.chromium.org/166903007/

In detail:
1. We need to skip the header on WindowMediaSource.idl (weird technicality)
2. We can now simplify the merge logic in interface_dependency_resolver.py
3. Remove unneeded test case TestImplements3.idl (only needed for
[LegacyImplementedInBaseClass])

I've also updated the docs:
https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-a...

Expand Messages | Collapse Messages