Source/bindings/scripts/unstable/interface_dependency_resolver.py - Issue 169273002: Remove support for [LegacyImplementedInBaseClass] IDL extended attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/unstable/interface_dependency_resolver.py

Issue 169273002: Remove support for [LegacyImplementedInBaseClass] IDL extended attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/unstable/interface_dependency_resolver.py

diff --git a/Source/bindings/scripts/unstable/interface_dependency_resolver.py b/Source/bindings/scripts/unstable/interface_dependency_resolver.py

index 90d7dd1052a35ce7803998adabc61e6f3134af73..27fe329dccb43f65d6612907617bc8c15d3012a4 100644

--- a/Source/bindings/scripts/unstable/interface_dependency_resolver.py

+++ b/Source/bindings/scripts/unstable/interface_dependency_resolver.py

@@ -170,10 +170,7 @@ def merge_dependency_interface(target_interface, dependency_interface, dependenc

def merge_lists(source_list, target_list):

for member in source_list:

member.extended_attributes.update(merged_extended_attributes)

- # FIXME: remove check for LegacyImplementedInBaseClass when this

- # attribute is removed

- if 'LegacyImplementedInBaseClass' not in dependency_interface.extended_attributes:

- member.extended_attributes['ImplementedBy'] = implemented_by

+ member.extended_attributes['ImplementedBy'] = implemented_by

target_list.append(member)

merge_lists(dependency_interface.attributes, target_interface.attributes)