Source/bindings/scripts/compute_dependencies.py - Issue 169273002: Remove support for [LegacyImplementedInBaseClass] IDL extended attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/compute_dependencies.py

Issue 169273002: Remove support for [LegacyImplementedInBaseClass] IDL extended attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/compute_dependencies.py

diff --git a/Source/bindings/scripts/compute_dependencies.py b/Source/bindings/scripts/compute_dependencies.py

index c14bc35c530eeb9770664c2decb879890242cb66..c2f43f4fe357d6978f3429aca2678d31cf6a01bb 100755

--- a/Source/bindings/scripts/compute_dependencies.py

+++ b/Source/bindings/scripts/compute_dependencies.py

@@ -332,11 +332,7 @@ def generate_dependencies(idl_filename):

extended_attributes = get_interface_extended_attributes_from_idl(idl_file_contents)

implemented_as = extended_attributes.get('ImplementedAs')

- this_include_path = (

- include_path(idl_filename, implemented_as)

- # implemented interfaces with [LegacyImplementedInBaseClass] have no

- # header of their own, as they just use the header of the base class

- if 'LegacyImplementedInBaseClass' not in extended_attributes else None)

+ this_include_path = include_path(idl_filename, implemented_as)

# Handle partial interfaces

partial_interface_name = get_partial_interface_name_from_idl(idl_file_contents)