Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: Source/bindings/scripts/generate_bindings.pl

Issue 169273002: Remove support for [LegacyImplementedInBaseClass] IDL extended attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/generate_bindings.pl
diff --git a/Source/bindings/scripts/generate_bindings.pl b/Source/bindings/scripts/generate_bindings.pl
index 67564d4d095d358f0739db056d5b43d62a69eb55..cf093e6263c532c1268d9078d88ac2fa51e240e4 100755
--- a/Source/bindings/scripts/generate_bindings.pl
+++ b/Source/bindings/scripts/generate_bindings.pl
@@ -115,7 +115,7 @@ foreach my $idlFile (@dependencyIdlFiles) {
# Support for attributes of partial interfaces.
foreach my $attribute (@{$interface->attributes}) {
# Record that this attribute is implemented by $interfaceName.
- $attribute->extendedAttributes->{"ImplementedBy"} = $interfaceName unless $interface->extendedAttributes->{"LegacyImplementedInBaseClass"};
+ $attribute->extendedAttributes->{"ImplementedBy"} = $interfaceName;
# Add interface-wide extended attributes to each attribute.
applyInterfaceExtendedAttributes($interface, $attribute->extendedAttributes);
@@ -126,7 +126,7 @@ foreach my $idlFile (@dependencyIdlFiles) {
# Support for methods of partial interfaces.
foreach my $function (@{$interface->functions}) {
# Record that this method is implemented by $interfaceName.
- $function->extendedAttributes->{"ImplementedBy"} = $interfaceName unless $interface->extendedAttributes->{"LegacyImplementedInBaseClass"};
+ $function->extendedAttributes->{"ImplementedBy"} = $interfaceName;
# Add interface-wide extended attributes to each method.
applyInterfaceExtendedAttributes($interface, $function->extendedAttributes);
@@ -137,7 +137,7 @@ foreach my $idlFile (@dependencyIdlFiles) {
# Support for constants of partial interfaces.
foreach my $constant (@{$interface->constants}) {
# Record that this constant is implemented by $interfaceName.
- $constant->extendedAttributes->{"ImplementedBy"} = $interfaceName unless $interface->extendedAttributes->{"LegacyImplementedInBaseClass"};
+ $constant->extendedAttributes->{"ImplementedBy"} = $interfaceName;
# Add interface-wide extended attributes to each constant.
applyInterfaceExtendedAttributes($interface, $constant->extendedAttributes);
« no previous file with comments | « Source/bindings/scripts/compute_dependencies.py ('k') | Source/bindings/scripts/unstable/interface_dependency_resolver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698