Issue 16917002: Rename chromium-win* ports to win*

Issue 16917002: Rename chromium-win* ports to win* (Closed)

Created:
7 years, 6 months ago by Steve Block

Modified:
7 years, 5 months ago

Reviewers:
Dirk Pranke, ojan

CC:
blink-reviews, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Rename chromium-win* ports to win* Also renames the ChromiumWinPort class to WinPort. A later change will update the relevant LayoutTest platform directories accordingly. BUG=231188 R=dpranke@chromium.org, ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153214

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -329 lines)			Patch
M	Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Tools/Scripts/webkitpy/common/host.py	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/base.py	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/builders.py	View	1 2 3 4	2 chunks	+6 lines, -6 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/chromium.py	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py	View	1 2 3 4	2 chunks	+3 lines, -3 lines	0 comments	Download
D	Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py	View		1 chunk	+0 lines, -147 lines	0 comments	Download
D	Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py	View	1 2	1 chunk	+0 lines, -133 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/factory.py	View		3 chunks	+8 lines, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py	View		2 chunks	+6 lines, -6 lines	0 comments	Download
A +	Tools/Scripts/webkitpy/layout_tests/port/win.py	View		4 chunks	+5 lines, -5 lines	0 comments	Download
A +	Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py	View	1 2	2 chunks	+18 lines, -18 lines	0 comments	Download

Total messages: 5 (0 generated)

Steve Block

If this looks OK, I'll tackle android, linux and mac in separate patches.

7 years, 6 months ago (2013-06-14 00:00:29 UTC) #1

ojan

lgtm This looks great! I'd prefer Dirk to give this his blessing before you commit ...

7 years, 6 months ago (2013-06-14 00:41:34 UTC) #2

Steve Block

OK, np. Note that https://codereview.chromium.org/16888010 needs to land first too.

7 years, 6 months ago (2013-06-14 05:15:56 UTC) #3

Steve Block

7 years, 5 months ago (2013-06-28 07:17:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r153214 (presubmit successful).