Tools/Scripts/webkitpy/layout_tests/port/win.py - Issue 16917002: Rename chromium-win* ports to win*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 16917002: Rename chromium-win* ports to win* (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/port/win.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py b/Tools/Scripts/webkitpy/layout_tests/port/win.py

similarity index 95%

rename from Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py

rename to Tools/Scripts/webkitpy/layout_tests/port/win.py

index 44ee3e86758182c2e4ebc675b5374994b4de9d17..dbb1ba86149a829e439be6f0a95defd9e5761384 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/win.py

@@ -26,7 +26,7 @@

# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-"""Chromium Win implementation of the Port interface."""

+"""Windows implementation of the Port interface."""

import os

import logging

@@ -37,8 +37,8 @@ import chromium

_log = logging.getLogger(__name__)

-class ChromiumWinPort(chromium.ChromiumPort):

- port_name = 'chromium-win'

+class WinPort(chromium.ChromiumPort):

+ port_name = 'win'

# FIXME: Figure out how to unify this with base.TestConfiguration.all_systems()?

SUPPORTED_VERSIONS = ('xp', 'win7')

@@ -50,7 +50,7 @@ class ChromiumWinPort(chromium.ChromiumPort):

@classmethod

def determine_full_port_name(cls, host, options, port_name):

- if port_name.endswith('-win'):

+ if port_name.endswith('win'):

assert host.platform.is_win()

# We don't maintain separate baselines for vista, so we pretend it is win7.

if host.platform.os_version in ('vista', '7sp0', '7sp1', 'future'):

@@ -62,7 +62,7 @@ class ChromiumWinPort(chromium.ChromiumPort):

def __init__(self, host, port_name, **kwargs):

chromium.ChromiumPort.__init__(self, host, port_name, **kwargs)

- self._version = port_name[port_name.index('chromium-win-') + len('chromium-win-'):]

+ self._version = port_name[port_name.index('win-') + len('win-'):]

assert self._version in self.SUPPORTED_VERSIONS, "%s is not in %s" % (self._version, self.SUPPORTED_VERSIONS)

def setup_environ_for_server(self, server_name=None):