Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 16888010: Fix RebaselineTest._copy_existing_baseline() to not assume that fallback directory names match port… (Closed)

Created:
7 years, 6 months ago by Steve Block
Modified:
7 years, 6 months ago
Reviewers:
Dirk Pranke, ojan
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Fix RebaselineTest._copy_existing_baseline() to not assume that fallback directory names match port names Port.baseline_version_dir() provides the default baseline path and this is not guaranteed to match the port name. So instead of making this assumption, search for a matching port. This is required to allow the 'chromium-' prefix to be removed from port names independently of renaming the fallback directories. BUG=231188 R=ojan Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Steve Block
7 years, 6 months ago (2013-06-14 05:15:04 UTC) #1
Dirk Pranke
lgtm.
7 years, 6 months ago (2013-06-17 19:35:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/16888010/1
7 years, 6 months ago (2013-06-17 23:43:31 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-18 00:48:21 UTC) #4
Message was sent while issue was closed.
Change committed as 152596

Powered by Google App Engine
This is Rietveld 408576698